Repository navigation
feat(search): add opt-in TESTS-signal to graph-stage (E17) - #39
Merged
Merged
Conversation
Append covering tests to symbol-search results behind MSCODEBASE_TESTS_SIGNAL (off by default, production unchanged). - SearchConfig.tests_signal (env flag, default false) - SymbolIndexAdapter.get_tests_for_symbol: incoming TESTS edges of a function - Searcher._append_tests_signal: up to 3 tests per function as separate rank (graph_score 0.4 vs 1.0), sentinel chunk_index -(20_000_000+line) - 7 unit tests in test_graph_stage_e4.py - Reproducible harnesses: e17_ab_tests_signal.py, e17_wide_panel.py (35 queries + language coverage), e17_redteam.py (5 attacks) Findings: hit@1 unchanged (94.3% both arms) - signal adds LLM context only; TESTS coverage Python 34.0%, Other/TypeScript 0%; red team 5/5 repelled. Article draft: docs/blog/bootstrap-pipeline.md
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ManSio
pushed a commit
that referenced
this pull request
Sep 22, 2026
- PR #39 merged (2026-09-22T09:13:51Z) - v3.5.0 pushed to main (6 commits) - E17 entry in EXPERIMENTS_LOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in TESTS-signal to symbol search (
graph-stage): covering tests(incoming
TESTSedges from the dynamic-trace bootstrap) are appended to foundfunction definitions as a separate, lower-ranked result group.
Behind
MSCODEBASE_TESTS_SIGNAL(env), off by default — production behavioris unchanged.
What changed
SearchConfig.tests_signal(env flag, defaultfalse).SymbolIndexAdapter.get_tests_for_symbol: resolves incomingTESTSedges for afunction, capped (hub functions like
safe_mkdirhave 234 tests).Searcher._append_tests_signal: appends up to 3 tests per function,graph_score = 0.4(vs 1.0 for definitions), sentinelchunk_index = -(20_000_000 + line)to avoid RRF collisions.tests/test_graph_stage_e4.py.e17_ab_tests_signal.py(narrow A/B),e17_wide_panel.py(35 queries + language coverage),e17_redteam.py(5 attacks).Findings (measured, not predicted)
LLM context only — it does not improve retrieval ranking.
covered by
TESTSedges; Other (Go/Rust) 0%; TypeScript 0%. The dynamictrace is Python-only.
(234-test hub = 16.11ms), abuse (nonexistent symbol → empty), TOCTOU (graph
closed mid-search → graceful), dependency failure (bad path → empty).
How to reproduce
Notes
docs/blog/bootstrap-pipeline.md.graph_score = 0.4is an empirical constant, unverified against reranker/BM25weight interactions — see "What Could Go Wrong" in the article.
verified_from_clean_state: this PR is what enables the clean-state check.