fix(remote_editor_install): restore correct editor name on macOS#189
Open
shiena wants to merge 1 commit into
Open
fix(remote_editor_install): restore correct editor name on macOS#189shiena wants to merge 1 commit into
shiena wants to merge 1 commit into
Conversation
f76d323 added guess_editor_name calls to update the name field when the user selects a file in the tree. On macOS, the extracted .app bundle is named simply "Godot.app" with no version info, so guess_editor_name falls back to the bare filename and overwrites the correct name that was derived from the downloaded zip. Add _pick_editor_name() which falls back to the zip-derived _initial_editor_name when guess_editor_name cannot extract a version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #188
f76d323 added guess_editor_name calls to update the name field when the user selects a file in the tree. On macOS, the extracted .app bundle is named simply "Godot.app" with no version info, so guess_editor_name falls back to the bare filename and overwrites the correct name that was derived from the downloaded zip.
Add _pick_editor_name() which falls back to the zip-derived _initial_editor_name when guess_editor_name cannot extract a version.