Skip to content

ui: offer Terminal and Desktop on every Keiki chat; the platform wakes the sandbox on open - #51

Merged
MrgSub merged 1 commit into
mainfrom
devin/1789024677-surfaces-on-demand
Sep 10, 2026
Merged

MrgSub merged 1 commit into
mainfrom
devin/1789024677-surfaces-on-demand

Conversation

@devin-ai-integration

Copy link
Copy Markdown

Summary

Terminal and Desktop were missing from the surface picker on Keiki conversations whose agent had never run a sandbox tool (e.g. api:5e9ee634-…:5d26257a… showed only "Conversations"): Comet probed GET …/terminal and hid both rows unless the platform had a sandbox on record. With Mail-0/sms-kit#984 the platform creates or wakes the sandbox when a terminal/desktop is opened, so the probe is gone and the rows are always offered — a click is what wakes the machine.

  • shell.rs: keiki_terminal_available, check_keiki_terminal, terminal_offered removed; Terminal row is unconditional, desktop_offered() is just is_keiki_chat(active_chat). Browser keeps its own live-handoff probe (check_keiki_browser) — a different runtime, untouched.
  • keiki-api: terminal_available removed; open_desktop returns Result<DesktopViewer, Error> (no None-on-404 branch).
  • desktop.rs: DesktopEvent::Gone and the EventEmitter impl removed; an open failure just closes the tab with the platform's message, as other errors already did.

Net −94 lines.

Link to Devin session: https://app.devin.ai/sessions/4bd4a708feed454e9aa48d0b31cc6b4a
Open in Devin Desktop: https://app.devin.ai/desktop/session/4bd4a708feed454e9aa48d0b31cc6b4a?variant=devin
Requested by: @MrgSub

@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@MrgSub
MrgSub merged commit 499cde9 into main Sep 10, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant