ui: offer Terminal and Desktop on every Keiki chat; the platform wakes the sandbox on open - #51
Merged
Merged
Conversation
…s the sandbox on open
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Terminal and Desktop were missing from the surface picker on Keiki conversations whose agent had never run a sandbox tool (e.g.
api:5e9ee634-…:5d26257a…showed only "Conversations"): Comet probedGET …/terminaland hid both rows unless the platform had a sandbox on record. With Mail-0/sms-kit#984 the platform creates or wakes the sandbox when a terminal/desktop is opened, so the probe is gone and the rows are always offered — a click is what wakes the machine.shell.rs:keiki_terminal_available,check_keiki_terminal,terminal_offeredremoved; Terminal row is unconditional,desktop_offered()is justis_keiki_chat(active_chat). Browser keeps its own live-handoff probe (check_keiki_browser) — a different runtime, untouched.keiki-api:terminal_availableremoved;open_desktopreturnsResult<DesktopViewer, Error>(noNone-on-404 branch).desktop.rs:DesktopEvent::Goneand theEventEmitterimpl removed; an open failure just closes the tab with the platform's message, as other errors already did.Net −94 lines.
Link to Devin session: https://app.devin.ai/sessions/4bd4a708feed454e9aa48d0b31cc6b4a
Open in Devin Desktop: https://app.devin.ai/desktop/session/4bd4a708feed454e9aa48d0b31cc6b4a?variant=devin
Requested by: @MrgSub