fix(MetroWindow): add GlowBrush dependency property (fixes #4564)#4568
Open
JyslaFancy wants to merge 1 commit into
Open
fix(MetroWindow): add GlowBrush dependency property (fixes #4564)#4568JyslaFancy wants to merge 1 commit into
JyslaFancy wants to merge 1 commit into
Conversation
…d GlowColor The MahApps.Metro documentation references a GlowBrush property on MetroWindow, but this property was never implemented. Users following the docs example get 'GlowBrush invalid property' at design time. The MetroWindow already inherits GlowColor (of type Color?) from ControlzEx.WindowChromeWindow. This commit adds a GlowBrush dependency property (of type Brush) that wraps GlowColor: - Setting GlowBrush extracts the Color from a SolidColorBrush and assigns GlowColor - Getting GlowBrush returns null (the underlying value is GlowColor) - Setting GlowBrush to null clears GlowColor Fixes MahApps#4564
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4564 — GlowBrush invalid property on MetroWindow.
Problem
The MahApps.Metro documentation references a GlowBrush property on MetroWindow, but this property was never implemented. Users following the docs example get 'GlowBrush invalid property' at design time.
Root cause
MetroWindow inherits GlowColor (Color?) from ControlzEx.WindowChromeWindow, but no GlowBrush convenience property was exposed.
Fix
Added a GlowBrush dependency property (of type Brush) that wraps the inherited GlowColor:
This matches the pattern used by other brush properties on MetroWindow (e.g. NonActiveBorderBrush).