Skip to content

fix(audit): stamp every entry with the service clock - #5

Merged
CalebSargeant merged 1 commit into
mainfrom
fix/audit-service-clock
Nov 10, 2026
Merged

CalebSargeant merged 1 commit into
mainfrom
fix/audit-service-clock

Conversation

@CalebSargeant

Copy link
Copy Markdown
Contributor

Audit entries now all take the console's own clock, which turns main's CI green again.

  • snapshot.shared, copy.dropped, snapshot.downloaded and every declined or withdrawn Job wrote the wall clock; the rest wrote the injected clock.
  • With the test clock fixed in October, requests and declines landed in different monthly blobs, so test_a_production_script_can_be_declined_or_withdrawn has failed since 1 November.
  • In production both clocks are datetime.now(UTC), so nothing changes there.
  • uv run pytest -q: 142 passed.

Four audit entries took the wall clock instead of the service's own, so the test clock put requests and declines in different monthly blobs and test_a_production_script_can_be_declined_or_withdrawn has failed on main since 1 November.
@brimyr

brimyr Bot commented Nov 10, 2026

Copy link
Copy Markdown

Brimyr: Quality Assurance

Mode: pr · Gate: pass · Ecosystem: Python

Metric Value
Patch coverage 100.0%
Covered / changed executable lines 3 / 3
Total coverage (measured files) 95.7%
Covered / executable lines across 23 file(s) 2852 / 2981
Threshold 80.0%

⚪ Only 3 changed executable line(s) — below the 20-line minimum, so the 80.0% threshold was not applied (patch coverage was 100.0%). Set min_lines: '0' to gate every diff.

@chargate

chargate Bot commented Nov 10, 2026

Copy link
Copy Markdown

Chargate: Security Assurance

Mode: pr · Gate: ✅ pass

Net-new Pre-existing Suppressed Total in full SARIF
0 0 1 1

✅ No net-new findings introduced by this change.

Uploaded: SARIF in DefectDojo · SBOM in Dependency-Track

Pre-existing findings never block; in-source suppressions (accepted risks) and secret false positives are reported but never gate. The full, unfiltered SARIF ships to the Security tab or as an artifact.

@CalebSargeant
CalebSargeant merged commit d549104 into main Nov 10, 2026
11 checks passed
@CalebSargeant
CalebSargeant deleted the fix/audit-service-clock branch November 10, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant