fix(cef): build cef_subprocess as a windowed app (no per-child console window)#231
Conversation
…e window) cef_subprocess is defined via add_executable() (console subsystem), so on Windows CEF spawns a black console window per child process (renderer/GPU/utility/... — several windows) when a client launches. Link it as /SUBSYSTEM:WINDOWS while keeping the int main() entry via /ENTRY:mainCRTStartup. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe CEF subprocess target now links with the Windows GUI subsystem while retaining the ChangesCEF subprocess build configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks @JEssou115 for this PR. Looks good to me, I am merging. |
Problem
On Windows, launching a
FrameworkClientpops several black console windows — one per CEF child process (renderer, GPU, utility, …).cef_subprocessis defined withadd_executable(...)without a windowed subsystem, so every CEF subprocess spawns with a console window.Fix
Link
cef_subprocesswith/SUBSYSTEM:WINDOWSwhile keeping itsint main()entry point via/ENTRY:mainCRTStartup. One line incode/framework/CMakeLists.txt— the subprocess runs identically, just without a console window. Consistent with the surrounding MSVC-only client block.Testing
Built on Windows (MSVC 14.44, RelWithDebInfo) — the CEF children no longer open console windows; the client and CEF views work as before.
🤖 Generated with Claude Code
Summary by CodeRabbit