feat(a11y): comprehensive VoiceOver accessibility audit fixes#293
Merged
Conversation
Addresses 18 accessibility gaps found across P0–P2 priority levels: P0 – Critical (VoiceOver users blocked): - MiniPlayerView: label skip/play buttons, expose open/dismiss as accessibility actions - Ticker: add accessibilityLabel with podcast title - SearchResultsList: apply cardAccessibility to news cards; podcast cards already self-apply - SearchView: announce searching/done/empty/error states via UIAccessibility - FeedHighlightsCarouselView: add accessibilityLabel + hint to each carousel button - CardAccessibilityModifier (NewsLibrary): make CardLabel, CardButton, cardAccessibility public - MenuView: add .isSelected trait to active category button P1 – High (degraded experience): - iOS Widget: create WidgetAccessibility+View.swift mirroring WatchWidget gold standard - MMWebView, DisqusWebView, SettingsView, DeepLinkNewsDetailView: label all xmark dismiss buttons "Fechar" - WebViewStatus: label ProgressView "Carregando conteúdo" - MetadataDuration: use accessibilityTime for human-readable time labels - PaginatedForEach: label loading indicator "Carregando mais conteúdo" P2 – Medium (polish): - GlassCardView, LeadingImageCard: mark decorative thumbnails accessibilityHidden(true) - FullPlayerView, ScrollStylePicker: remove .dynamicTypeSize(.medium) lock so Dynamic Type works - SocialView: replace empty Picker label with "Seção social" - RecentSearchesView: add .isHeader trait to "Recentes", clarify "Limpar" button label - NewsView: label chevron.backward back button "Voltar" Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cardAccessibilityto news cards in search results, fix carousel cards, and add.isSelectedtrait toMenuViewcategory buttonsxmarkdismiss buttons "Fechar", label WebView loading indicator, fixMetadataDurationto use human-readable time, labelPaginatedForEachloading indicatoraccessibilityHidden(true), remove Dynamic Type lock in podcast player speed controls, fix emptyPickerlabel inSocialView, add.isHeadertrait to recent searches section header, label the news detail back button "Voltar"Test plan
xmarkbuttons across Settings, WebView, DisqusSheet, and DeepLink read "Fechar"xcodebuild build✅ |swiftlint lint --strict✅🤖 Generated with Claude Code