Repository navigation
Conversation
Owner
Author
|
维护方向调整:这个修复基于 issue #7 报告者的根因分析,应由报告者自己提交 PR 以保留署名贡献。本 PR 关闭,分支 fix/browser-login-cdp 保留(含全部修复与测试),供报告者 fork cherry-pick 或参考。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
#7 指出 Windows 候选顺序会先选中注册了 App Paths 的夸克,而不是系统默认 Edge;夸克的内部页又会扰动
/json/list并回收登录 page target,最终把“目标消失”误报成“用户关了窗口”。改动
UserChoice与默认浏览器 open command,仅让 CDP 稳定白名单浏览器优先;夸克降为所有候选的最后兜底。MAGPIE_BROWSER与MAGPIE_BROWSER_PREFER_DEFAULT=0两个显式控制入口。/json/list第一项。reg query丢弃正常探测产生的 stderr。验证
维护者本地:补丁直接相关的
tests/browser-login.test.mjs+tests/session-login.test.mjs19/19 通过;node scripts/check.mjs、npm pack --dry-run、git diff --check通过。全量npm test中tests/today-spend.test.mjs有 2 项失败,已在干净 main 基线 worktree 复现同样 2 项(既有时区/日期问题,与本补丁无关),未夹带修改;以 PR CI(UTC)结果为准。未验证
真实 Windows + 夸克/Edge 的端到端登录仍需真机复验;本 PR 不把“断开原因分类”写成“自动重连”。既有
chromiumLogin默认cookieNames=[]的必然超时问题单列,未夹带在本 PR。Refs #7