Skip to content

Add Lemmy 1.0.0 support#87

Open
MV-GH wants to merge 111 commits into
masterfrom
lemmy-1.0.0
Open

Add Lemmy 1.0.0 support#87
MV-GH wants to merge 111 commits into
masterfrom
lemmy-1.0.0

Conversation

@MV-GH

@MV-GH MV-GH commented May 24, 2026

Copy link
Copy Markdown
Owner

Seems to work in initial basic tests.

its deployed https://central.sonatype.com/artifact/it.vercruysse.lemmyapi/lemmy-api-jvm

@dessalines

dessalines commented May 26, 2026

Copy link
Copy Markdown
Contributor

Nice, thx. We'll try to get the version stuff figured out quickly. Unfortunately I gotta go back to work on lemmy-ui again as a lot of issues just popped up there.

@dessalines

Copy link
Copy Markdown
Contributor

Another thing I'm noticing working through jerboa, the CommentActions aren't matching.

lemmy 1.0 uses CommentActions.vote_is_upvote: Boolean? , but in this PR its val like_score: Int = 0

@MV-GH

MV-GH commented Jul 7, 2026

Copy link
Copy Markdown
Owner Author

Eh didnt really like the true|null|false, so kept the previous behaviour to reduce the refactoring burden. But I dont rlly mind it. But I would prob make into an enum (Upvote/Downvote/NoVote)

@dessalines

Copy link
Copy Markdown
Contributor

An enum would be fine too, although IMO its best to use as minimal transforms from the original API as possible. Up to you.

@dessalines

Copy link
Copy Markdown
Contributor

Another minor issue that means this might need to be regenerated: community title is now optional.

@dessalines

Copy link
Copy Markdown
Contributor

Another related to votes: VoteView has pub is_upvote: bool , but in the API its still a numeric score

@MV-GH MV-GH deployed to publish July 8, 2026 20:57 — with GitHub Actions Active
@dessalines

Copy link
Copy Markdown
Contributor

Sweet, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants