Skip to content

Default Frontier templates to hackathon QOS/partition#1407

Merged
sbryngelson merged 6 commits intoMFlowCode:masterfrom
sbryngelson:hackathon-frontier
May 7, 2026
Merged

Default Frontier templates to hackathon QOS/partition#1407
sbryngelson merged 6 commits intoMFlowCode:masterfrom
sbryngelson:hackathon-frontier

Conversation

@sbryngelson
Copy link
Copy Markdown
Member

Summary

  • Sets --partition=batch and --qos=hackathon as defaults in frontier.mako and frontier_amd.mako
  • Values remain overridable via -p and -q CLI flags

Test plan

  • Verify batch job submission on Frontier uses hackathon QOS without needing -q/-p flags
  • Verify -p and -q overrides still work as expected

@qodo-code-review
Copy link
Copy Markdown
Contributor

ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Claude Code Review

Head SHA: 4600b40

Files changed:

  • 2
  • toolchain/templates/frontier.mako
  • toolchain/templates/frontier_amd.mako

Findings

Hardcoded hackathon QOS will break normal Frontier job submissions (frontier.mako, frontier_amd.mako)

Both templates replace the conditional partition and quality_of_service rendering with static values:

#SBATCH --partition=batch
#SBATCH --qos=hackathon

The hackathon QOS is an event-specific queue on OLCF Frontier that only exists during hackathon periods. Hardcoding it means every job submitted via ./mfc.sh run -e batch -c f (or the AMD variant) will fail with an invalid QOS error whenever a hackathon is not active. This is a regression from the previous behavior where partition and quality_of_service were passed in dynamically by the user and only emitted if provided.

The prior conditional logic:

% if partition:
#SBATCH --partition=${partition}
% endif
% if quality_of_service:
#SBATCH --qos=${quality_of_service}
% endif

allowed ordinary production runs (which use the standard batch partition and a project allocation QOS) to work correctly. Removing that flexibility and replacing it with a hackathon-specific QOS appears to be a temporary change that was not reverted before merge.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Warning

Rate limit exceeded

@sbryngelson has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 19 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f3ec22b7-41e1-48a3-908d-3ac29a83321e

📥 Commits

Reviewing files that changed from the base of the PR and between 7305683 and 1d57af8.

📒 Files selected for processing (4)
  • .github/scripts/submit-slurm-job.sh
  • src/simulation/p_main.fpp
  • toolchain/templates/frontier.mako
  • toolchain/templates/frontier_amd.mako

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sbryngelson sbryngelson merged commit c99ac2d into MFlowCode:master May 7, 2026
50 of 136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant