Skip to content

fix double counted n14agf18wk rate in net - #1057

Merged
wmwolf merged 3 commits into
mainfrom
EbF/bugfix/duplicate_rates_in_nets
Sep 3, 2026
Merged

wmwolf merged 3 commits into
mainfrom
EbF/bugfix/duplicate_rates_in_nets

Conversation

@Debraheem

Copy link
Copy Markdown
Member

This address the issue opened by @zingale in #1056

@Debraheem
Debraheem requested a review from rhdtownsend as a code owner August 31, 2026 15:25
@Debraheem Debraheem added bug Something isn't working rates-net Rates and net modules labels Aug 31, 2026
@Debraheem
Debraheem requested a review from warrickball as a code owner August 31, 2026 20:03
@zingale

zingale commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

thanks @Debraheem

@Debraheem
Debraheem requested a review from wmwolf September 2, 2026 02:29
@wmwolf

wmwolf commented Sep 3, 2026

Copy link
Copy Markdown
Member

Aside from some unrelated FPE issues on the testhub, looks good. Thanks for pointing this out @zingale and for patching it up, @Debraheem!

@wmwolf
wmwolf merged commit c968766 into main Sep 3, 2026
5 checks passed
Comment thread data/net_data/nets/cno_extras_o18_to_mg26.net
@zingale

zingale commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

cno_extras_o18_to_mg26.net has:

include 'add_cno_extras'

and add_cno_extras has:

include 'add_hot_cno'

So add_hot_cno gets included eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working rates-net Rates and net modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

double counting N14(a,γ)F18(β+)O18 in nova test suite / cno_extras_o18_to_mg26.net

4 participants