docs: CLAUDE.md and api/app.py both said remote TLS exposure is later -- it already shipped - #609
docs: CLAUDE.md and api/app.py both said remote TLS exposure is later -- it already shipped#609wshallwshall wants to merge 5 commits into
Conversation
… -- it already shipped
ADR 0172 (Accepted 2026-08-22) made the engine always serve TLS: an operator-supplied
[api].tls_cert_file wins if configured, otherwise the engine mints and reuses a self-signed pair
on first run. build_api_ssl_context is wired into serve's uvicorn ssl_context_factory at
__main__.py:2861-2868. Both docs still described the pre-ADR-0172 state.
Left docs/adr/0068-browser-webauthn-passkeys-offloopback.md's citation of the old CLAUDE.md
wording alone -- it is an explicit verbatim historical quote ("CLAUDE.md and test-enforced
invariants, verbatim where quoted"), not a live claim, and rewriting a dated ADR's quotation of
what a doc said at the time would misrepresent the ADR's own history.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
LANDER: auto-merge DISARMED. This PR must land AFTER PR #575, not before. WHY, measured 2026-08-27 at main 58e710a:
WHAT WAS ACTUALLY HOLDING IT: The other red leg on this PR ( TO RELEASE: land #575, then update this branch. The link resolves and the prose becomes true at the same commit. Alternatively, if #575 is going to sit, rewrite this PR to describe main as it is and drop the 0172 link. Not a rebuild request. The content is fine; the ordering is the whole issue. |
ADR 0172 (Accepted 2026-08-22) made the engine always serve TLS: an operator-supplied
[api].tls_cert_filewins if configured, otherwise the engine mints and reuses a self-signed pairon first run.
build_api_ssl_contextis wired intoserve's uvicornssl_context_factoryat__main__.py:2861-2868. BothCLAUDE.mdandapi/app.py's module docstring still described thepre-ADR-0172 state ("remote TLS exposure is later"), which is the file every session reads first.
Left
docs/adr/0068-browser-webauthn-passkeys-offloopback.md's citation of the old wording alone-- it's an explicit verbatim historical quote of what CLAUDE.md said at the time that ADR was
written, not a live claim, and rewriting it would misrepresent the ADR's own history.
Flagged by Dispatcher's board (BLOCKERS section), verified directly against the actual wiring
before fixing.
Built by Lander.
🤖 Generated with Claude Code