training features for 7net-omni - #311
Merged
Merged
Conversation
for more information, see https://pre-commit.ci
Contributor
Author
|
@Jaesun0912 |
YutackPark
reviewed
Jun 9, 2026
Member
|
reg_functions 가 loss_functions 랑 동일하게 돌아가게 하면 (설계 의도대로) 코드가 한 번 더 확 줄어들어요. 구체적으로는 trainer 에서 분기가 사라져요. 사용례는 제가보기에 둘이 사실상 똑같고 init 할때 reg functions 는 config 이상으로 model_keys 가 필요하다는 차이가 있는데 이건 그냥 기존 함수를 확장하면 됩니다. weight 에 2 나눠서 쓰는건 "_preprocess" 에다가 넣으면 됩니다. |
YutackPark
previously approved these changes
Jun 26, 2026
working_dir was bound to train_loader_key, so lc.csv was written to cwd instead of working_dir. Pass it as a keyword arg. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V97TGG8YJ8fWT6eXM75WWC
Member
|
Feel free to merge! I'm happy after the last commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #276