bench: drive HTTP/3 with h2load built with ngtcp2/nghttp3, not h3x - #279
Merged
Merged
Conversation
h3x reports completed requests over its whole run, and the run waits ~30 s on any request that never finishes: a dozen stuck streams made a server doing ~300k req/s read as ~50k. h2load's rate covers the run it reports. H2LOAD_H3 points at it (default ~/h3x/bench/h2load). any.sh also discards a run whose h2load requests failed, errored or timed out, or came back non-2xx - which the h2c/h2 rows never checked. h2load counts a request killed with its connection as neither failed nor errored, only not done, so a run is also discarded when nothing completed or a connection completed nothing: 32 one-MiB responses per connection, every connection closed at the send backstop, read as an unsaturated 0.00 req/s rather than a failure. That 0.00 also slipped past the zero check, which compared strings.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
h3x reports completed requests over its whole run, and the run waits ~30 s on any request that never finishes: a dozen stuck streams made a server doing ~300K req/s read as ~50K.
bench/lib.shnow drives HTTP/3 with an h2load built with ngtcp2/nghttp3 (H2LOAD_H3, default~/h3x/bench/h2load- the distro's h2load 1.59 has no HTTP/3), whose rate covers the run it reports.any.shdiscards a run whose h2load requests failed, errored or timed out, or came back non-2xx - which the h2c/h2 rows never checked either. h2load counts a request killed with its connection as neither failed nor errored, only not done, so a run is also discarded when nothing completed or a connection completed nothing. And h2load's0.00 req/sno longer slips past the zero check, which compared strings.What it still cannot see is a stream left open when a duration run ends - that is simply in flight. The hangs fixed in #278 never showed in h2load; those are for the tests (or h3x, which waits on them).
Checked
Http3/Nghttp3Buffered: 739,295 req/s, 2.71 µs/req.Http3/ManagedBufferedwith 1 MiB bodies (PLAYGROUND_BODY=1048576) on main's code:discarded: no request completed. Before the stricter checks it readunsaturated (2%)at 0.00 req/s.bench/results/latest.jsonis untouched.