Repository navigation
Fix Deploy sign-in: trust GitHub's ID-based OIDC subject - #14
Merged
Merged
Conversation
The first real Deploy run failed at sign-in (AADSTS700213): GitHub presented repo:<owner>@<owner-id>/<repo>@<repo-id>:ref:refs/heads/main, while the identity only trusted the name-only subject. make github-identity now creates both credentials (still main of this repo only) and adds a missing one on a re-run. Test first. Also adds the Azure smoke tests used in #11. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Seen on the first successful Deploy run: tr turned the empty plan into a single space, so the build step ran with no services instead of the 'Every service already runs' step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first real Deploy run (#11) failed at Azure sign-in with AADSTS700213. GitHub sent
repo:<owner>@<owner-id>/<repo>@<repo-id>:ref:refs/heads/main, but the identity only trusted the name-only subject.make github-identitynow creates both federated credentials. Both are still limited to main of this repo. A re-run adds whichever one is missing. Tested first: the repo-root suite has 61 tests.This PR also adds
tests/smoke/test_post_provision_azure.py. Its 4 Azure checks passed in the #11 run.Refs #11
🤖 Generated with Claude Code