Skip to content

Fix Deploy sign-in: trust GitHub's ID-based OIDC subject - #14

Merged
MAOFILHO merged 3 commits into
mainfrom
m3b/oidc-subject
Nov 16, 2026
Merged

MAOFILHO merged 3 commits into
mainfrom
m3b/oidc-subject

Conversation

@MAOFILHO

Copy link
Copy Markdown
Owner

The first real Deploy run (#11) failed at Azure sign-in with AADSTS700213. GitHub sent repo:<owner>@<owner-id>/<repo>@<repo-id>:ref:refs/heads/main, but the identity only trusted the name-only subject.

make github-identity now creates both federated credentials. Both are still limited to main of this repo. A re-run adds whichever one is missing. Tested first: the repo-root suite has 61 tests.

This PR also adds tests/smoke/test_post_provision_azure.py. Its 4 Azure checks passed in the #11 run.

Refs #11

🤖 Generated with Claude Code

MAOFILHO and others added 3 commits November 15, 2026 20:09
The first real Deploy run failed at sign-in (AADSTS700213): GitHub presented
repo:<owner>@<owner-id>/<repo>@<repo-id>:ref:refs/heads/main, while the identity only trusted the
name-only subject. make github-identity now creates both credentials (still main of this repo
only) and adds a missing one on a re-run. Test first. Also adds the Azure smoke tests used in #11.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Seen on the first successful Deploy run: tr turned the empty plan into a single space, so the
build step ran with no services instead of the 'Every service already runs' step.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MAOFILHO
MAOFILHO merged commit 3dc8b75 into main Nov 16, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant