Repository navigation
M3b part 1: commit-tagged Azure images, M3a config in Azure, path-filtered CI, Deploy workflow - #12
Merged
Merged
Conversation
…ath-filtered CI, Deploy workflow - #5: provision tags every Azure image with the 12-char commit and passes it in as GIT_SHA; the registry is no longer built for Azure. - #6: Redis as an internal TCP Container App (1 replica, imported into ACR), REDIS_URL for order and inventory, the inventory address for order, and a provision-generated signing key stored as a Container Apps secret. make resume keeps Redis at exactly 1 replica. Cost record updated. - #7: scripts/ci_changes.py turns the changed files into CI matrices from the service table; PRs run only what they touch, main runs everything. - #8: make github-identity (owner runs it): OIDC app registration limited to this repo's main branch and the project resource group; ids stored as masked GitHub secrets; provision re-grants the role after each teardown. - #9: manual Deploy workflow (main only, actions pinned to SHAs): rebuilds services whose code changed since their running commit, rolls them out, records image size, shown on the Containerization page. All logic built test-first (implement skill): 42 repo-root tests, 131 unit tests in all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two-axis review (standards + spec against #5-#9). Fixes, each with a failing test first except the two workflow-only steps (Deploy health wait, CI ok job), which the Azure run (#11) proves: - One source: services Azure runs, their folders and the resource group come from the service table (azure/shared flags); Deploy reads them through deploy_plan.py instead of hardcoding. - provision --skip-build reuses the last built tag instead of pointing apps at a tag never pushed; re-runs keep the signing key (no logout); provision records image sizes for the page. - CI: pytest.ini runs everything; an unknown pact provider fails loudly; Deploy ignores CI-only files; a multi-platform manifest reports unknown size instead of crashing. - Identity: role granted by object id (no replication race), exact app-name match, GitHub secrets written only when missing or after a new app. - Deploy waits until each service answers with the new commit, else fails the run. - CI: actions pinned to SHAs, base branch passed via env, one always-run "CI ok" job to require. - Redis no longer receives the MySQL secret; its no-password scope is documented. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of M3b (see "M3 review" in docs/PLAN.md, decision 4). Closes #5, closes #6, closes #9. Refs #7 (one later PR still has to show the skipped jobs) and #8 (a human ticket: this PR ships the script, and the owner runs it).
What it does
GIT_SHA. The registry is no longer built for Azure.REDIS_URLfor order and inventory, and the inventory address for order. Without that address, checkout's stock-hold step would fail in Azure.make resumekeeps Redis at exactly 1 replica.scripts/ci_changes.py). One always-run job, CI ok, is the check to require if branch protection is added.make github-identity(the owner runs it):rg-microservices-12-patterns.make provisiongrants its role again after each teardown.Review
Matt Pocock code review on both axes found 13 standards findings and 9 spec findings. All were fixed, each with a failing test first except 2 steps that only exist in the workflow (see the commit message).
Tests
🤖 Generated with Claude Code