-
Notifications
You must be signed in to change notification settings - Fork 0
112 path sum #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
112 path sum #25
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,69 @@ | ||||||||||||
| # 112. Path Sum | ||||||||||||
|
|
||||||||||||
| https://leetcode.com/problems/path-sum/ | ||||||||||||
|
|
||||||||||||
| ## step1(まず通す) | ||||||||||||
|
|
||||||||||||
| ノードを全部探索して、条件に該当するものが見つかったら return true すればいい。 | ||||||||||||
|
|
||||||||||||
| ループで書くなら (node, sum_so_far) みたいに持ちたい。その場合は深さ優先探索でも幅優先探索でもいいが、該当するパスが見つかった時点で return できるので深さ優先探索の方が見るノード数が少なくて済むことが多そう。 | ||||||||||||
| 他の方のコードでよく見かける `forntiers` という変数名を使ってみた。 | ||||||||||||
|
|
||||||||||||
| 再帰でも書ける(step1-2.py)。一本道だと再帰呼び出しの回数がノード数(最大 5000)になるので、注意が必要(Python の再帰呼び出し回数の上限はデフォルトだと 1000) | ||||||||||||
|
|
||||||||||||
| ## step2(整形&他の人のコードを読む) | ||||||||||||
|
|
||||||||||||
| - https://github.com/naoto-iwase/leetcode/pull/29#discussion_r2455081026 | ||||||||||||
| - 「もし葉でtargetSumになるような経路を返却するとしたらどうでしょうか?設問としてはTrue/Falseなのですが、単純にTrue/Falseを得るよりはpathを実際に知るほうが意味があるのかなと思ったので...自分が面接だったら質問しそうです。」 | ||||||||||||
| - 葉から根へ向かうのは親を辿っていけば一本道でたどり着くので、探索しながら各ノードの親を覚えておく `node_to_parent: dict[TreeNode, TreeNode` 辞書を作って、葉から順番に辿っていけば良さそう。 | ||||||||||||
| - 全部のパスを返す必要があるなら、見つかった時点での return をやめて全ノードを探索すれば良い。 | ||||||||||||
| - パスを一つだけ見つければ良いという条件で再帰で書くなら↓のようになるだろうか。空リストより None が良いかもしれないのと、パスを探すならパスの存在自体が T/F の代わりになるので bool を返す必要はなさそう。全部のパスを返す場合は、返すのがパスのリスト = ノードのリストのリストになってだいぶ煩雑な気がする。 | ||||||||||||
|
Comment on lines
+16
to
+20
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. この議論はいいですね.勉強になりました. |
||||||||||||
|
|
||||||||||||
| ```python | ||||||||||||
| class Solution: | ||||||||||||
| def hasPathSum( | ||||||||||||
| self, root: Optional[TreeNode], target_sum: int | ||||||||||||
| ) -> tuple[bool, list[TreeNode]]: | ||||||||||||
| if root is None: | ||||||||||||
| return False, [] | ||||||||||||
|
|
||||||||||||
| if root.left is None and root.right is None: | ||||||||||||
| if root.val == target_sum: | ||||||||||||
| return True, [root] | ||||||||||||
| else: | ||||||||||||
| return False, [] | ||||||||||||
|
|
||||||||||||
| child_target_sum = target_sum - root.val | ||||||||||||
| left_has_path, path = self.hasPathSum(root.left, child_target_sum) | ||||||||||||
| if left_has_path: | ||||||||||||
| path.append(root) | ||||||||||||
| return True, path | ||||||||||||
|
|
||||||||||||
| right_has_path, path = self.hasPathSum(root.right, child_target_sum) | ||||||||||||
| if right_has_path: | ||||||||||||
| path.append(root) | ||||||||||||
| return True, path | ||||||||||||
|
|
||||||||||||
| return False, [] | ||||||||||||
| ``` | ||||||||||||
|
|
||||||||||||
| - https://discord.com/channels/1084280443945353267/1225849404037009609/1258455843226255361 | ||||||||||||
| - 「引き算先にしちゃって、...のほうが素直ではないでしょうか。」 | ||||||||||||
| - 確かにそう。 | ||||||||||||
|
|
||||||||||||
| ```python | ||||||||||||
| class Solution: | ||||||||||||
| def hasPathSum(self, root: Optional[TreeNode], target_sum: int) -> bool: | ||||||||||||
| if root is None: | ||||||||||||
| return False | ||||||||||||
|
|
||||||||||||
| children_target_sum = target_sum - root.val | ||||||||||||
| if root.left is None and root.right is None: | ||||||||||||
| return children_target_sum == 0 | ||||||||||||
|
|
||||||||||||
| return self.hasPathSum(root.left, children_target_sum) or self.hasPathSum( | ||||||||||||
| root.right, children_target_sum | ||||||||||||
| ) | ||||||||||||
|
Comment on lines
+64
to
+66
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pythonに詳しくないのですが,こういう改行のほうが嬉しいかなと思いました.
Suggested change
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ありがとうございます。私も同じようなことは思ったのですが、ruff という標準的なフォーマッター(兼リンター)の一つをデフォルト設定で使ってこのようになるので今回はこれを採用しました。 見た目でいうと以下のようなものがよさそうでしょうか。(ただしこれも ruff でフォーマットすると元のコードに戻されます) return (
self.hasPathSum(root.left, children_target_sum)
or self.hasPathSum(root.right, children_target_sum)
)細かいところを補足しますと、
という感じのようです。 |
||||||||||||
| ``` | ||||||||||||
|
|
||||||||||||
| ## step3(10分以内にさっとかける \* 3回) | ||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| from typing import Optional | ||
|
|
||
|
|
||
| class TreeNode: | ||
| def __init__(self, val=0, left=None, right=None): | ||
| self.val = val | ||
| self.left = left | ||
| self.right = right | ||
|
|
||
|
|
||
| class Solution: | ||
| def hasPathSum(self, root: Optional[TreeNode], target_sum: int) -> bool: | ||
| if root is None: | ||
| return False | ||
|
|
||
| if root.left is None and root.right is None and root.val == target_sum: | ||
| return True | ||
|
|
||
| children_target_sum = target_sum - root.val | ||
| return self.hasPathSum(root.left, children_target_sum) or self.hasPathSum( | ||
| root.right, children_target_sum | ||
| ) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| from typing import Optional | ||
|
|
||
|
|
||
| class TreeNode: | ||
| def __init__(self, val=0, left=None, right=None): | ||
| self.val = val | ||
| self.left = left | ||
| self.right = right | ||
|
|
||
|
|
||
| class Solution: | ||
| def hasPathSum(self, root: Optional[TreeNode], target_sum: int) -> bool: | ||
| if root is None: | ||
| return False | ||
|
|
||
| frontiers = [(root, 0)] | ||
| while frontiers: | ||
| node, sum_so_far = frontiers.pop() | ||
| sum_so_far += node.val | ||
| if node.left is None and node.right is None and sum_so_far == target_sum: | ||
| return True | ||
|
|
||
| if node.left is not None: | ||
| frontiers.append((node.left, sum_so_far)) | ||
| if node.right is not None: | ||
| frontiers.append((node.right, sum_so_far)) | ||
|
|
||
| return False |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| from typing import Optional | ||
|
|
||
|
|
||
| class TreeNode: | ||
| def __init__(self, val=0, left=None, right=None): | ||
| self.val = val | ||
| self.left = left | ||
| self.right = right | ||
|
|
||
|
|
||
| class Solution: | ||
| def hasPathSum(self, root: Optional[TreeNode], target_sum: int) -> bool: | ||
| if root is None: | ||
| return False | ||
|
|
||
| frontiers = [(root, target_sum)] | ||
| while frontiers: | ||
| node, rest = frontiers.pop() | ||
| rest -= node.val | ||
| if node.left is None and node.right is None: | ||
| if rest == 0: | ||
| return True | ||
| else: | ||
| continue | ||
|
|
||
| if node.left is not None: | ||
| frontiers.append((node.left, rest)) | ||
| if node.right is not None: | ||
| frontiers.append((node.right, rest)) | ||
|
|
||
| return False |
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 再帰とiterative, 両方書いていてよいなと思いました. 全体的に読みやすかったです |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| from typing import Optional | ||
|
|
||
|
|
||
| class TreeNode: | ||
| def __init__(self, val=0, left=None, right=None): | ||
| self.val = val | ||
| self.left = left | ||
| self.right = right | ||
|
|
||
|
|
||
| class Solution: | ||
| def hasPathSum(self, root: Optional[TreeNode], target_sum: int) -> bool: | ||
| if root is None: | ||
| return False | ||
|
|
||
| frontiers = [(root, target_sum)] | ||
| while frontiers: | ||
| node, rest = frontiers.pop() | ||
| rest -= node.val | ||
| if node.left is None and node.right is None: | ||
| if rest == 0: | ||
| return True | ||
| else: | ||
| continue | ||
|
|
||
| if node.left is not None: | ||
| frontiers.append((node.left, rest)) | ||
| if node.right is not None: | ||
| frontiers.append((node.right, rest)) | ||
|
|
||
| return False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
余裕があれば,実際にかかる時間やメモリを見積もってみてもいいかもしれません
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます。余裕のある時は見積もるようにします