add snotel super sites support#152
Open
broberts-pierel wants to merge 1 commit into
Open
Conversation
micah-prime
requested changes
May 21, 2026
Contributor
micah-prime
left a comment
micah-prime
left a comment
There was a problem hiding this comment.
One comment on consistent naming, everything else looks great!
| ( | ||
| "SWOTV", | ||
| SensorDescription, | ||
| field(default=SensorDescription("SWOTV", "SHORTWAVE OUTGOING", "SHORTWAVE RADIATION OUTGOING")), |
Contributor
There was a problem hiding this comment.
What do you think about changing these names to UPWARD SHORTWAVE RADIATION and DOWNWARD SHORTWAVE RADIATION instead of SHORTWAVE OUTGOING to match the naming we used in the CUES variables? That would make the resulting dataframe parsing consistent if we used more than one data source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a few variables to the Metloom snotel class to pull additional data types for the super sites.