chore: remove agentmemory MCP service (migrated to synapse)#25
Merged
Conversation
Native first-party MCPs (synapse, grimoire) cover the need, so the opt-in external agentmemory service is removed. Its 76 logged memories were migrated to synapse's global store first (one-time, verified recallable; migration script was ephemeral, not kept in-repo). - registry/optional-services.json: drop the agentmemory service entry - .gitmodules + external/agentmemory: deinit + remove the submodule - adapters/droid/README.md, external/README.md, mcps/synapse/README.md, registry/target-capabilities.json, targets.mjs comment: drop agentmemory as a live/installable example (kept generic 'external MCPs are opt-in' wording) - tests: drop the --service agentmemory opt-in cases (no external MCP remains to exercise them); deepagents MCP test now asserts the default first-party servers; inventory external count 7 -> 6 Design-history references (why synapse rejected agentmemory as a base) in concept-zero/architecture/roadmap/redactor + CHANGELOG are intentionally retained. check / check generated / check rules / build / test all green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native first-party MCPs (synapse, grimoire) cover the need, so the opt-in external
agentmemoryservice is removed.Migration first (no data loss)
Its 76 logged memories were migrated into synapse's global store before removal — verified recallable (
store:"global", content + tags preserved). The migration was a one-time ephemeral script drivingsynapse-bridgeover stdio MCP; per the "don't keep one-off scripts" rule it is not committed.Removal
registry/optional-services.json— drop theagentmemoryservice entry..gitmodules+external/agentmemory— deinit + remove the submodule.adapters/droid/README.md,external/README.md,mcps/synapse/README.md,registry/target-capabilities.json,targets.mjscomment — drop agentmemory as a live/installable example; keep the generic "external MCPs are opt-in" wording.tests— remove the--service agentmemoryopt-in cases (no external MCP remains to exercise them); the deepagents MCP test now asserts the default first-party servers (grimoire, synapse); inventory external count 7 → 6.Retained (intentional): the design-history references explaining why synapse rejected agentmemory as a base —
concept-zero.md(E-01–E-03),architecture.md,roadmap.md(P3.3),redactor.ts(redaction-floor rationale), and theCHANGELOGentry.Verification
check·check generated·check rules·build --target all·test— all green.by mass-energy equivalence