Skip to content

Assignment - #1

Open
LuissaVahedi wants to merge 3 commits into
mainfrom
assignment
Open

Assignment#1
LuissaVahedi wants to merge 3 commits into
mainfrom
assignment

Conversation

@LuissaVahedi

Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Making a new function and testing it

What did you learn from the changes you have made?

I learned how to create functions and sanity check them

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I wanted to see about printing different outputs for the function but I decided to keep it simple

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

No

How were these changes tested?

I added a section on sanity checking the lofic of the function to confirm it works

A reference to a related issue in your repository (if applicable)

No

Checklist

  • [ x] I can confirm that my changes are working as intended

@monzchan monzchan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

"anagram_checker(\"Silent\", \"listen\", True) # False"
"anagram_checker(\"Silent\", \"listen\", True) # False\n",
"\n",
"# I am confused as to why the parameter is True. Clearly \"Silent\" and \"listen\" are not case sensitive."

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you put True here in "anagram_checker("Silent", "listen", True)" is actually meaning that you want the logics to consider case sensitivity. And since it is case sensitivity, the outcome is False - capital S for Silent and small s for listen.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I understand now. That was not clear from the question stem but I understand the logic now. I assume that I dont need to change anyting for this assignment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants