Blood Elf Female Havoc Metamorphosis wrong offset

[zcourge]

When entering Meta, the offset shifts about twice as far to the side as with the regular model.

When trying to manually edit the hardcoded offsets in factors.lua, the offset shifted for both the belf model, and the meta form. It seems it doesn't correctly apply.

Regular female belf:

Meta havoc:

This is with the same zoom level (9.0)

[zcourge]

I noticed that if I open up /cfsf while in Metamorphosis, the offset adjusts correctly to what it's supposed to be, however, exiting the form (bringing you back to regular belf) again screws with the offset correction, and now the belf model is not corrected properly. Again, entering /cfsf and exiting fixes this, and returns the belf model offset back to where it should be.

[zcourge]

One issue that I found while trying to fix it myself was that the offset gets updated while other UNIT_AURA events get fired off, and the correction function thinks metamorphosis isn't active, while it is. A workaround could be to use the modelid for offsets like regular player models, instead of using the demonhunterFormToShoulderOffsetFactor. Not sure if this would work differently based on race, but I digress.

I managed to fix it for myself at the moment of writing this, but I'm pretty sure it's not good enough for a PR as it is still a bit buggy, sometimes not reverting back to correct offset when returning out of the meta form. LMK if you want me to open a PR with whatever I have got going on right now.

Another big issue I found, is that the GetDemonHunterForm function that's used both in correction.lua and event.lua (hardcoded in one of them) runs into issues in combat, as the UNIT_AURA event sometimes becomes secret, and thus it returns 0 even though you're in meta form. Modelid also changes, so this might be a better way of detecting the form in the future?