Skip to content

Fix unlocking of attachments when not using a master key #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Skulblaka wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix unlocking of attachments when not using a master key #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions Passwork/Attachment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,18 +52,25 @@ private async Task Unlock()
//get the details about this password
var singleitem = await conn.Get<AttachmentSingleItem>($"passwords/{parent.Id}/attachment/{Id}");

var vsi = await this.conn.Get<VaultSingleItem>($"vaults/{parent.VaultId}");
IVault vault = new Vault(conn, vsi);
if (conn.WithMasterPassword)
{
var vsi = await this.conn.Get<VaultSingleItem>($"vaults/{parent.VaultId}");
IVault vault = new Vault(conn, vsi);

var masterPass = await vault.GetMaster();
var key = CryptoUtils.Decode(singleitem.encryptedKey, masterPass);
var masterPass = await vault.GetMaster();
var key = CryptoUtils.Decode(singleitem.encryptedKey, masterPass);

//TODO i skipped the has check..
//if (cryptoInterface.hash(byteCharacters) !== attachment.hash)
//{
// throw "Can't decrypt attachment: hashes are not equal";
//}
data = CryptoUtils.DecodeFile(singleitem.encryptedData, key);
//TODO i skipped the has check..
//if (cryptoInterface.hash(byteCharacters) !== attachment.hash)
//{
// throw "Can't decrypt attachment: hashes are not equal";
//}
data = CryptoUtils.DecodeFile(singleitem.encryptedData, key);
}
else
{
data = Convert.FromBase64String(Base64.Decode(singleitem.encryptedData));
}
}


Expand Down