Conversation
Normalize explicit and environment-variable keys, treating blank values as unset. Add regression coverage for whitespace, fallback, and precedence. Fixes LuckyPennySoftware#4660
|
|
AVTUNEY
marked this pull request as ready for review
September 28, 2026 18:00
Contributor
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
License keys copied from PDFs, email, or secret files can contain whitespace and fail signature validation. Normalize each key source before applying the existing explicit → AutoMapper environment variable → shared environment variable precedence, treating empty and whitespace-only values as unset.
Add 34 regression cases covering trailing and embedded ASCII/Unicode whitespace, precedence, and fallback. All 34 fail against the original resolver and pass with this fix.
Validation:
pwsh -NoProfile -File ./Build.ps1: passed (1,430 tests total).Fixes #4660