fix(windows): hide native titlebar on Windows - #178
Open
arafuls wants to merge 1 commit into
Open
Conversation
The app already draws its own titlebar/window controls on Windows, so disable native decorations there too (previously only Linux). Also exclude DECORATIONS from tauri-plugin-window-state's tracked flags — it defaults to persisting/restoring decoration state per-window, which silently overrode the builder setting on subsequent launches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a duplicate titlebar on Windows: the native OS titlebar was showing alongside the app's own custom-drawn titlebar/window controls.
Changes
DECORATIONSfromtauri-plugin-window-state's tracked flags. It defaults to persisting/restoring decoration state per-window, which silently overrode the builder setting on subsequent launches.Related Issues
Closes #166
Screenshots / Demos (if applicable)
Windows 11
Checklist
Breaking Changes (if any)
Please test this on MacOS/Linux as I do not have them available currently.
Additional Context
Existing users have a
.window-state.jsonwithdecorated: truesaved from before this fix. Without the plugin flag change, that stale value would keep overriding the new decorations setting on every launch, so both changes are required together.Reviewers
@LovelessCodes