Skip to content

Accept namespaced Deep Linking settings - #29

Merged
ottenhoff merged 1 commit into
LongsightGroup:mainfrom
ottenhoff:codex/sakai-deep-linking-extensions
Sep 2, 2026
Merged

ottenhoff merged 1 commit into
LongsightGroup:mainfrom
ottenhoff:codex/sakai-deep-linking-extensions

Conversation

@ottenhoff

Copy link
Copy Markdown
Member

Summary

  • accept unknown Deep Linking settings only when their property name is an absolute HTTPS URI
  • preserve URI-named extension values in the parsed raw claim
  • reject ordinary unknown, insecure HTTP, and malformed keys
  • cover the four Sakai extension keys reported by CredTrail issue docs: postgres and mysql shipped, D1 requested lti-tool/lti-tool#97

Verification

  • npm run lint
  • npm run format
  • npm run type-check
  • npm test -- --run (296 tests)
  • npm run build
  • npm run smoke-test:dist

Downstream: LongsightGroup/credtrail-private#97

@ottenhoff
ottenhoff merged commit 6622120 into LongsightGroup:main Sep 2, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant