♻️ anonymise SecurityEvent/ImportRun identifiers on account deletion (LK-C04) - #138
Merged
Merged
Conversation
…LK-C04) SecurityEvent.identifier and ImportRun.identifier denormalised the account's email at write time and were never cleared, so a deleted account's email survived indefinitely in these two audit tables — contradicting the privacy policy's stated retention. identifier is now only ever written for LOGIN_FAILED (a login attempt's raw target string, independent of any account); every other event type derives its display email from a join on userId at read time, so it anonymises itself the moment the FK is nulled by the account's deletion instead of needing an explicit purge step. Also corrects the privacy policy's "Données de sécurité" row, which described Loki/file log rotation rather than this table.
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SecurityEvent.identifier and ImportRun.identifier denormalised the account's email at write time and were never cleared, so a deleted account's email survived indefinitely in these two audit tables — contradicting the privacy policy's stated retention. identifier is now only ever written for LOGIN_FAILED (a login attempt's raw target string, independent of any account); every other event type derives its display email from a join on userId at read time, so it anonymises itself the moment the FK is nulled by the account's deletion instead of needing an explicit purge step. Also corrects the privacy policy's "Données de sécurité" row, which described Loki/file log rotation rather than this table.
Closes https://github.com/Logan2234/loomkeep-roadmap/issues/8