fix: gate fork affordances on completed replies - #779
Merged
Merged
Conversation
Keep streaming context copy available through a direct copy action while reserving the fork control and its persistent loading state for finished assistant turns. Model: gpt-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AssistantForkButtonand the pending-fork loading state now requiremessage.finished === true; a pending fork no longer keeps the action group force-visible on an unfinished turn.be09f427, authored 2026-09-11) rebased onto current main: the streaming context-copy test is ported to thecreateConversationViewFromHistoryharness from feat: read long conversations by window with shared history writes #376, theai-guiAGENTS.md rule is added within the 8 KiB gate, and the Agent Note ships its zh counterpart.conversation-context-copy-and-text-attachmentsupdated (still draft): a streaming reply must not show a Fork affordance or Fork loading state.Test plan
NODE_ENV=test pnpm vitest run tests/session-fork-destination-menu.test.tsx tests/chat-virtual-rows-identity.test.ts tests/assistant-turn-action-inset.test.ts— 23 tests pass (streaming case asserts no fork button, direct copy action works; finished case keeps fork menu)pnpm --filter @lody/components typecheck— cleanpnpm run docs check— 0 errorspnpm lint:fast/lint:i18n— cleanpnpm format— no changes neededGenerated with Devin