Conversation
ladydd
marked this pull request as ready for review
September 9, 2026 14:08
This was referenced Sep 9, 2026
ladydd
force-pushed
the
fix/pin-codex-compact-kill-waiters
branch
from
September 11, 2026 06:27
6cb4a82 to
9232a8b
Compare
Contributor
Author
This was referenced Sep 11, 2026
Pin acp-extension-codex to a67f231 (LodyAI/acp-extension-codex#38, rebased onto current adapter main / 5f0aab0) so compaction waiters reject when the Codex process exits. Other submodules stay on current main. Depends on adapter LodyAI#38. Do not ship a desktop release until that merge. Closes LodyAI#550
Agent Note for pinning acp-extension-codex a67f231 (adapter LodyAI#38) so /compact does not hang when the process exits after start.
ladydd
force-pushed
the
fix/pin-codex-compact-kill-waiters
branch
from
September 12, 2026 16:22
9232a8b to
168809d
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #550
Depends on LodyAI/acp-extension-codex#38. Review this host PR, then merge the adapter first and this pin second. Do not ship a desktop release until that adapter merge exists.
Problem / pressure
/compactwaits on athread/compactednotification. Turn waiters already reject when the Codex process exits; compaction waiters were resolve-only. If app-server dies afterthread/compact/start, the ACP prompt never finishes. Host Stop does not clear it. The next prompt isalready active. Healthy compact still works. Mid-turn process death already returns-32603. This is the compact waiter hole, not the fork hang (#543 / #544) and not adapter #30 (stop during compact).Summary
Pin
acp-extension-codexto31c5ecc(adapter #38, rebased onto current adapter main /314b3823) so close/dispose rejects compaction waiters. Other submodules stay on current main.Visual explanation
Before / after
/compact+ process death stays compacting; Stop thenalready active-32603; next prompt is notalready active/compact314b3823(host #275 / adapter cancel-compaction)31c5ecc(#38 on top of that main)Test plan
vitest run src/__tests__/CodexAppServerClient.test.ts --no-file-parallelism --retry=0— 7 passed, including close while start is still in flight.-32603in 10ms with noalready active; restart +loadSessionthen history, a normal prompt, and another compact all completed. Lifecycle 8/8 included real vscode-jsonrpc close while start was pending. Related adapter regression 130 passed; the known/reviewslash-command timeout is a pre-existing baseline skip.pnpm run docs checkreported no errors on the new note pair; the command still fails on pre-existing broken links in unrelated notes/specs. Fullpnpm checkwas not re-run on this pin-only host worktree.-32603classification.Context handoff
Instructions for reviewing agents
314b3823→31c5eccand that Core / other submodules are unchanged.31c5eccbefore Fix/electron local file browser #38 merges; no in-window desktop compact-kill on this pin.Authoring context
31c5ecc/ Fix/electron local file browser #38).pnpm checkon this worktree.Original user prompt