perf(components): lazy-load settings tab bodies off the shell - #495
Closed
slashdevcorpse wants to merge 2 commits into
Closed
slashdevcorpse wants to merge 2 commits into
slashdevcorpse wants to merge 2 commits into
Conversation
Route files and the desktop modal load each tab through lazy(), matching archive.tsx. Navigate-only legacy settings routes stay eager. Model: grok-4.6
BillingSettingsRoute suspends behind RouteSuspense, so the first mobile render was empty until the mocked chunk resolved. Model: grok-4.6
Contributor
|
@slashdevcorpse, this pull request was closed because it did not meet Lody's contribution requirements for 7 days. Open a new pull request using the current template to continue contributing this change. This pull request will not be reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #493
Problem / pressure
Electron does not enable TanStack auto code-splitting.
routeTree.gen.tsstatically imports every settings route, and those files plusDesktopSettingsModalstatically import tab bodies (MCP, billing, stats, agent config). Authenticated-shell cold start parses that graph before Settings opens.Summary
Settings tab bodies load through
lazy()from each route file, matchingarchive.tsx, and fromSettingsTabContentin the desktop modal. Navigate-only legacy routes (general,stats,devices,my-machines,agent-config) are unchanged. Whole-appautoCodeSplittingis not enabled.Before / after
lazy()behindSuspense.Test plan
pnpm exec prettier --writeon the changed settings routes anddesktop-settings-modal.tsx.Context handoff
Instructions for reviewing agents
lazy()wrappers insettings/*.tsx(except Navigate-only legacy routes) anddesktop-settings-modal.tsxSettingsTabContent.lazy()instead of enablingautoCodeSplittinginelectron.vite.config.ts.Suspense fallback={null}while a tab chunk loads.Authoring context
fallback={null}).