fix: unblock session writes by skipping full-state validation - #463
Merged
Merged
Conversation
Keep the HistoryWriter refactor separate from the availability hotfix. Model: gpt-6
Model: gpt-6
zxch3n
marked this pull request as ready for review
September 7, 2026 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Independent availability hotfix; the HistoryWriter work remains deferred in PR #460.
Problem / pressure
Full-state Mirror validation rejects valid local sends when unrelated synchronized history contains an unknown item type or a malformed known item. The writer refactor has broader fork and rollback interactions and should not be an urgent prerequisite.
Summary
Set
validateUpdates: falseat the two existing session Mirror construction sites (renderer and CLI). No new writer, schema, dependency, storage, copy, rollback, or transport changes. Other Mirrors and explicit external-input parsers retain their existing checks.Add real-Loro regressions and a production construction-site check. Record the temporary trade-off in a bilingual Agent Note and draft Spec.
Before / after
Test plan
pnpm checkstopped at missing dependencies in other packages of this isolated worktree; clean-install CI remains required.Context handoff
Instructions for reviewing agents
Authoring context