Fix culture-sensitive Maths.mhd parsing#211
Open
valcryst wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maths.mhd uses a fixed dot decimal separator, but LoadMaths parsed its
floating-point fields using the current culture. On comma-decimal locales,
values such as 0.700 could be interpreted as 700, inflating enhancement and
ED percentages by a factor of 1,000.
Parse only the Maths.mhd numeric fields with NumberStyles.Float and
CultureInfo.InvariantCulture while preserving the existing load-error
behavior.
This issue was discovered while working on Mids Linux.
I was unable to test the upstream Windows application because I do not have access to a Windows system.