Skip to content

refactor: fix Sonar type hints and nested contexts - #625

Merged
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar-fixes
Oct 4, 2026
Merged

ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar-fixes

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Fixes sonar issues.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@sonarqubecloud

sonarqubecloud Bot commented Oct 4, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.94%. Comparing base (a837b88) to head (a3d77ff).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
- Coverage   76.00%   75.94%   -0.06%     
==========================================
  Files          26       26              
  Lines        2096     2091       -5     
==========================================
- Hits         1593     1588       -5     
  Misses        503      503              
Files with missing lines Coverage Δ
src/common/database.py 95.29% <100.00%> (-0.02%) ⬇️
src/common/rank.py 58.57% <100.00%> (ø)
src/common/rank_database.py 96.77% <100.00%> (ø)
src/common/sponsors.py 100.00% <100.00%> (ø)
src/discord_bot/cogs/fun_commands.py 50.00% <100.00%> (-1.43%) ⬇️
src/discord_bot/cogs/moderator_commands.py 26.08% <ø> (-1.06%) ⬇️
src/discord_bot/cogs/rank.py 49.56% <ø> (-0.22%) ⬇️
src/discord_bot/cogs/support_commands.py 86.04% <100.00%> (-0.17%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a837b88...a3d77ff. Read the comment docs.

@ReenigneArcher
ReenigneArcher merged commit d991cc2 into master Oct 4, 2026
19 checks passed
@ReenigneArcher
ReenigneArcher deleted the refactor/sonar-fixes branch October 4, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant