fix(server): harden liftOver/TransVar subprocesses and auto-restart t… - #65
Merged
Conversation
…he API container TransVar and liftOver were spawned with no timeout, so a hung binary (bad input, disk stall reading the reference files) left the request hanging forever - the same failure mode just fixed for external HTTP calls in f0f33a3. Both now get a timeout with SIGKILL as the fallback. liftover.js also leaked its temporary BED files on every error path, only cleaning up on full success; over time this fills /tmp and starves the host. Cleanup now runs in a finally block regardless of outcome. Finally, the server container had no restart policy, so any crash left the API down until someone SSHed in to run docker compose up again. restart: unless-stopped lets Docker recover it automatically. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…he API container
TransVar and liftOver were spawned with no timeout, so a hung binary (bad input, disk stall reading the reference files) left the request hanging forever - the same failure mode just fixed for external HTTP calls in f0f33a3. Both now get a timeout with SIGKILL as the fallback.
liftover.js also leaked its temporary BED files on every error path, only cleaning up on full success; over time this fills /tmp and starves the host. Cleanup now runs in a finally block regardless of outcome.
Finally, the server container had no restart policy, so any crash left the API down until someone SSHed in to run docker compose up again. restart: unless-stopped lets Docker recover it automatically.