Skip to content

LF-5311 (2) Remove reference to /shared/locales from cp-uncompiled-to-dist#4187

Merged
SayakaOno merged 1 commit into
integrationfrom
LF-5311-2-cleanup-crowd-in-in-preparation-for-new-language-khmer
Jun 5, 2026
Merged

LF-5311 (2) Remove reference to /shared/locales from cp-uncompiled-to-dist#4187
SayakaOno merged 1 commit into
integrationfrom
LF-5311-2-cleanup-crowd-in-in-preparation-for-new-language-khmer

Conversation

@kathyavini
Copy link
Copy Markdown
Collaborator

@kathyavini kathyavini commented Jun 5, 2026

Description

Thank you @SayakaOno for spotting the failed deploy!

Cleanup of the unused files packages/shared/locales in #4185 should have also included removing this now unused part of cp-uncompiled-to-dist in packages/api/package.json -- that locales/ folder is entirely absent (although it's not super clear from the GitHub diff alone that this is so!)

Jira link: https://lite-farm.atlassian.net/browse/LF-5311

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Ran locally: npm run build && npm run cp-uncompiled-to-dist

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini self-assigned this Jun 5, 2026
@kathyavini kathyavini requested review from a team as code owners June 5, 2026 22:59
@kathyavini kathyavini requested review from SayakaOno and removed request for a team June 5, 2026 22:59
@kathyavini kathyavini added the bug Something isn't working label Jun 5, 2026
Copy link
Copy Markdown
Collaborator

@SayakaOno SayakaOno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@SayakaOno SayakaOno added this pull request to the merge queue Jun 5, 2026
Merged via the queue into integration with commit eea6b4b Jun 5, 2026
6 checks passed
@SayakaOno SayakaOno deleted the LF-5311-2-cleanup-crowd-in-in-preparation-for-new-language-khmer branch June 5, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants