LF-5311 (2) Remove reference to /shared/locales from cp-uncompiled-to-dist#4187
Merged
SayakaOno merged 1 commit intoJun 5, 2026
Conversation
SayakaOno
approved these changes
Jun 5, 2026
Collaborator
SayakaOno
left a comment
There was a problem hiding this comment.
Looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thank you @SayakaOno for spotting the failed deploy!
Cleanup of the unused files
packages/shared/localesin #4185 should have also included removing this now unused part ofcp-uncompiled-to-distinpackages/api/package.json-- that locales/ folder is entirely absent (although it's not super clear from the GitHub diff alone that this is so!)Jira link: https://lite-farm.atlassian.net/browse/LF-5311
Type of change
How Has This Been Tested?
Ran locally:
npm run build && npm run cp-uncompiled-to-distChecklist:
pnpm i18nto help with this)