Bump op-node to v1.19.6 and op-reth to v2.4.3 (PLAT-788) - #141
Conversation
Pin op-node to v1.19.6 (97e2f94) and op-reth to v2.4.3 (b12d746) in reth/Dockerfile; update README client versions and source-tree link. Both upstream releases are required only for World Chain and strongly recommended otherwise. Their breaking changes are inert here: op-reth now rejects --minimal at startup (unused in reth-entrypoint), and op-node drops cross_unsafe_l2 from optimism_syncStatus (the README example reads unsafe_l2). Verified for this bump: - op-node-lisk-sepolia.patch still applies; system_config.go is byte-identical between v1.19.5 and v1.19.6. - GOLANG_VERSION=1.26 stays aligned with go.mod (go 1.26.0) and RUST_VERSION=1.95 with rust/rust-toolchain.toml. - superchain-registry moves 7715c7d -> 08d6a44, which leaves lisk and lisk-sepolia untouched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe PR updates the pinned ChangesOptimism version update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The dependency pin and documentation updates are ready to merge with no outstanding current-head risk identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
A rabbit checks the pins with care Comment |
Both pins were annotated tag objects, not commits. The optimism monorepo nests release tags twice (ref -> tag -> tag -> commit), so dereferencing once yields a tag SHA that is indistinguishable from a commit SHA by inspection. The Dockerfile asserts the clone landed on the expected commit, so the build failed at `[ "$(git rev-parse HEAD)" = "$COMMIT" ]` on both platforms with a bare exit code 1 -- the clone and git switch succeed first, which makes it read as a clone failure. Both tags resolve to b60a1a6, upstream having cut the two releases from the same monorepo commit; the identical value across the two stages is expected. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Summary
Bumps both client versions:
Upstream marks both required for World Chain, strongly recommended otherwise. For the Lisk image the reachable part is the deposit-transaction (
0x7E) decoding hardening plus op-node's transitive Go security updates; the Karst activations both releases lead with, the interop span-batch fix, AltDA input sizing and the sequencer-shutdown fix are all out of scope (verifier only, no interop, no AltDA).Changes
reth/DockerfileVERSION=v1.19.5→v1.19.6;COMMIT→b60a1a6398209ccc47267e77deb6e4bf4c1ede8areth/DockerfileVERSION=op-reth/v2.4.2→op-reth/v2.4.3;COMMIT→b60a1a6398209ccc47267e77deb6e4bf4c1ede8aREADME.mdop-reth%2Fv2.4.3Upstream breaking changes
--minimalat startup (#22108)--minimaland every prune flag are absent repo-wide, in all entrypoint branchescross_unsafe_l2fromoptimism_syncStatus(#22555)unsafe_l2, unaffected. Operators' own dashboards/alerts readingcross_unsafe_l2must repoint — called out in the release draftChecks
COMMITpinsb60a1a6398209ccc47267e77deb6e4bf4c1ede8a, confirmed a commit object and the target of both tags. Upstream nests these tags twice (ref → tag → tag → commit); the first push pinned the intermediate tag objects and CI failed the Dockerfile'sgit rev-parse HEADassertion — fixed in 9e7d005. Identical SHA across both stages is expected: upstream cut both releases from one monorepo commitop-node-lisk-sepolia.patchvs v1.19.6op-node/rollup/derive/system_config.gois byte-identical between v1.19.5 and v1.19.6 (blob7b368b2), and it applied clean at v1.19.5GOLANG_VERSION=1.26go.mod(go 1.26.0); only thetoolchaindirective movedgo1.26.5→go1.26.6RUST_VERSION=1.95rust/rust-toolchain.toml(channel = "1.95")superchain-registrysubmodule pin (embedded configs, both clients)7715c7d→08d6a44; touches only World Chain, a sepolia devnet and validation data —liskandlisk-sepoliauntouchedhickory-resolverNSEC3 advisory (GHSA-3v94-mw7p-v465, high)DnssecDnsHandle, and reth linkshickory-resolverwithout any DNSSEC feature (crates/net/dns/Cargo.toml:features = ["tokio"]). Holds for EL-sync nodes too, where discovery is livedocker-compose*.yml,.env.*, entrypoints, workflows)No entrypoint, flag, env or peer-config change; no data migration.
Release
Draft v0.4.28 is staged against
mainand covers this PR only —v0.4.27is atmainhead, so there are no other unreleased changes. Publish after merge.🤖 Generated with Claude Code
Summary by CodeRabbit