Skip to content

Bump op-node to v1.19.6 and op-reth to v2.4.3 (PLAT-788) - #141

Merged
sameersubudhi merged 2 commits into
mainfrom
plat-788-bump-op-node-to-v1196-and-op-reth-to-v243
Sep 9, 2026
Merged

sameersubudhi merged 2 commits into
mainfrom
plat-788-bump-op-node-to-v1196-and-op-reth-to-v243

Conversation

@sameersubudhi

@sameersubudhi sameersubudhi commented Sep 9, 2026

Copy link
Copy Markdown
Member

Summary

Bumps both client versions:

Upstream marks both required for World Chain, strongly recommended otherwise. For the Lisk image the reachable part is the deposit-transaction (0x7E) decoding hardening plus op-node's transitive Go security updates; the Karst activations both releases lead with, the interop span-batch fix, AltDA input sizing and the sequencer-shutdown fix are all out of scope (verifier only, no interop, no AltDA).

Changes

# File Change
1 reth/Dockerfile op-node VERSION=v1.19.5v1.19.6; COMMITb60a1a6398209ccc47267e77deb6e4bf4c1ede8a
2 reth/Dockerfile op-reth VERSION=op-reth/v2.4.2op-reth/v2.4.3; COMMITb60a1a6398209ccc47267e77deb6e4bf4c1ede8a
3 README.md Both client versions + release links; op-reth source-tree link → op-reth%2Fv2.4.3

Upstream breaking changes

# Change Impact here
1 op-reth rejects --minimal at startup (#22108) None — --minimal and every prune flag are absent repo-wide, in all entrypoint branches
2 op-node drops cross_unsafe_l2 from optimism_syncStatus (#22555) README sync check reads unsafe_l2, unaffected. Operators' own dashboards/alerts reading cross_unsafe_l2 must repoint — called out in the release draft

Checks

# Check Result
1 COMMIT pins Both stages pin b60a1a6398209ccc47267e77deb6e4bf4c1ede8a, confirmed a commit object and the target of both tags. Upstream nests these tags twice (ref → tag → tag → commit); the first push pinned the intermediate tag objects and CI failed the Dockerfile's git rev-parse HEAD assertion — fixed in 9e7d005. Identical SHA across both stages is expected: upstream cut both releases from one monorepo commit
2 op-node-lisk-sepolia.patch vs v1.19.6 Still applies — op-node/rollup/derive/system_config.go is byte-identical between v1.19.5 and v1.19.6 (blob 7b368b2), and it applied clean at v1.19.5
3 GOLANG_VERSION=1.26 Still aligned with op-node's go.mod (go 1.26.0); only the toolchain directive moved go1.26.5go1.26.6
4 RUST_VERSION=1.95 Still matches op-reth's rust/rust-toolchain.toml (channel = "1.95")
5 superchain-registry submodule pin (embedded configs, both clients) Advanced 7715c7d08d6a44; touches only World Chain, a sepolia devnet and validation data — lisk and lisk-sepolia untouched
6 op-reth hickory-resolver NSEC3 advisory (GHSA-3v94-mw7p-v465, high) Not reachable — the flaw is in hickory's DnssecDnsHandle, and reth links hickory-resolver without any DNSSEC feature (crates/net/dns/Cargo.toml: features = ["tokio"]). Holds for EL-sync nodes too, where discovery is live
7 Other version references (docker-compose*.yml, .env.*, entrypoints, workflows) None

No entrypoint, flag, env or peer-config change; no data migration.

Release

Draft v0.4.28 is staged against main and covers this PR only — v0.4.27 is at main head, so there are no other unreleased changes. Publish after merge.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • Updated documented client versions to op-node v1.19.6 and op-reth v2.4.3.
    • Updated the referenced op-reth source to v2.4.3.
    • Updated the bundled client sources to op-node v1.19.6 and op-reth v2.4.3, ensuring builds use the corresponding revisions.

Pin op-node to v1.19.6 (97e2f94) and op-reth to v2.4.3 (b12d746) in
reth/Dockerfile; update README client versions and source-tree link.

Both upstream releases are required only for World Chain and strongly
recommended otherwise. Their breaking changes are inert here: op-reth
now rejects --minimal at startup (unused in reth-entrypoint), and
op-node drops cross_unsafe_l2 from optimism_syncStatus (the README
example reads unsafe_l2).

Verified for this bump:
- op-node-lisk-sepolia.patch still applies; system_config.go is
  byte-identical between v1.19.5 and v1.19.6.
- GOLANG_VERSION=1.26 stays aligned with go.mod (go 1.26.0) and
  RUST_VERSION=1.95 with rust/rust-toolchain.toml.
- superchain-registry moves 7715c7d -> 08d6a44, which leaves lisk and
  lisk-sepolia untouched.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 3a7e9083-373d-4570-8d21-3ab3e6d190ac

📥 Commits

Reviewing files that changed from the base of the PR and between aedfb38 and 9e7d005.

📒 Files selected for processing (1)
  • reth/Dockerfile

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The PR updates the pinned op-node and op-reth commit targets and synchronizes their documented versions and source-tree link.

Changes

Optimism version update

Layer / File(s) Summary
Update source version pins
reth/Dockerfile
The Dockerfile updates the op-node and op-reth commit verification targets. Their version pins remain v1.19.6 and v2.4.3.
Synchronize version documentation
README.md
The README documents op-node v1.19.6 and op-reth v2.4.3. The source-tree link points to v2.4.3.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 9e7d0

The dependency pin and documentation updates are ready to merge with no outstanding current-head risk identified.

Suggested reviewers: nazgolze

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely identifies the primary change: updating op-node to v1.19.6 and op-reth to v2.4.3.
Description check ✅ Passed The description is detailed and relevant. It explains the version bump, implementation changes, compatibility checks, testing evidence, upstream breaking changes, and release plan. It uses alternate h…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch plat-788-bump-op-node-to-v1196-and-op-reth-to-v243

A rabbit checks the pins with care
New versions hop through build and page
The source link follows neatly there
Two commits rest in careful stage
The burrow ships a fresher age

Comment @coderabbitai help to get the list of available commands.

@sameersubudhi sameersubudhi self-assigned this Sep 9, 2026
Both pins were annotated tag objects, not commits. The optimism monorepo
nests release tags twice (ref -> tag -> tag -> commit), so dereferencing
once yields a tag SHA that is indistinguishable from a commit SHA by
inspection.

The Dockerfile asserts the clone landed on the expected commit, so the
build failed at `[ "$(git rev-parse HEAD)" = "$COMMIT" ]` on both
platforms with a bare exit code 1 -- the clone and git switch succeed
first, which makes it read as a clone failure.

Both tags resolve to b60a1a6, upstream having cut the two releases from
the same monorepo commit; the identical value across the two stages is
expected.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@sameersubudhi
sameersubudhi enabled auto-merge (squash) September 9, 2026 07:59
@sameersubudhi
sameersubudhi merged commit 6493784 into main Sep 9, 2026
3 checks passed
@sameersubudhi
sameersubudhi deleted the plat-788-bump-op-node-to-v1196-and-op-reth-to-v243 branch September 9, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants