Skip to content

feat(TeamCard): add honorofkings Legacy Custom for slot-index icons#7599

Draft
Eetwalt wants to merge 5 commits into
mainfrom
tc-lw-hok
Draft

feat(TeamCard): add honorofkings Legacy Custom for slot-index icons#7599
Eetwalt wants to merge 5 commits into
mainfrom
tc-lw-hok

Conversation

@Eetwalt
Copy link
Copy Markdown
Collaborator

@Eetwalt Eetwalt commented Jun 2, 2026

Summary

⚠️ Drafted and to be opened later because:

For slot index remapping on ENC games, it may need to wait until after the cut offs. There is a risk that it will move points between players. Only can be done if all ENC tournaments is already using TP

  • Add Module:TeamCard/Legacy/Custom for honorofkings so pos-less cards (KPL / HoK International style) recover their auto role icons under the new TeamParticipants pipeline via slot-index defaulting
  • Renumber InGameRoles sortOrder to a contiguous lineup order (top=1, jungler=2, mid=3, bottom=4, roamer=5, side lane=6, flex=7) so INGAME_ROLES_BY_ORDER[1..5] resolves correctly — standard 5-man lineups sort unchanged

How did you test this change?

dev (live in prod)

Copilot AI review requested due to automatic review settings June 2, 2026 09:58
@Eetwalt Eetwalt requested review from a team as code owners June 2, 2026 09:58
@Eetwalt Eetwalt added g: honorofkings Honor of Kings / Arena of Valor c: team_participant labels Jun 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an Honor of Kings-specific Legacy TeamCard customization to restore auto role icons (via slot-index position defaulting) when running through the newer TeamParticipants pipeline, and adjusts HoK in-game role ordering so the “by sortOrder” index mapping aligns with standard 5-player lineups.

Changes:

  • Added lua/wikis/honorofkings/TeamCard/Legacy/Custom.lua implementing preprocessCard to migrate legacy posN params and default missing pNpos by slot index.
  • Renumbered sortOrder in lua/wikis/honorofkings/InGameRoles.lua to a contiguous lineup order so INGAME_ROLES_BY_ORDER[1..5] resolves correctly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
lua/wikis/honorofkings/TeamCard/Legacy/Custom.lua Adds HoK-specific Legacy TeamCard hook to migrate/normalize position params and default roles by slot index.
lua/wikis/honorofkings/InGameRoles.lua Updates role sortOrder values to ensure consistent lineup ordering for slot-index role defaults.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lua/wikis/honorofkings/TeamCard/Legacy/Custom.lua
Comment thread lua/wikis/honorofkings/InGameRoles.lua Outdated
@Rathoz
Copy link
Copy Markdown
Collaborator

Rathoz commented Jun 2, 2026

For slot index remapping on ENC games, it may need to wait until after the cut offs. There is a risk that it will move points between players. Only can be done if all ENC tournaments is already using TP

@Eetwalt
Copy link
Copy Markdown
Collaborator Author

Eetwalt commented Jun 2, 2026

For slot index remapping on ENC games, it may need to wait until after the cut offs. There is a risk that it will move points between players. Only can be done if all ENC tournaments is already using TP

Oh, maybe we should then wait for cut offs on the TP rollout then for wikis that need the remapping as missing role icons doesn't look great especially for pages that are inputting some roles manually and some rely on import.

The changes from this PR is live for HoK via dev modules, so if this is blocker I will revert the template conversions

@Eetwalt
Copy link
Copy Markdown
Collaborator Author

Eetwalt commented Jun 2, 2026

For slot index remapping on ENC games, it may need to wait until after the cut offs. There is a risk that it will move points between players. Only can be done if all ENC tournaments is already using TP

Oh, maybe we should then wait for cut offs on the TP rollout then for wikis that need the remapping as missing role icons doesn't look great especially for pages that are inputting some roles manually and some rely on import.

The changes from this PR is live for HoK via dev modules, so if this is blocker I will revert the template conversions

Just checked and most ENC tournaments are using TCs so rolling back now just to be safe

@Eetwalt Eetwalt marked this pull request as draft June 2, 2026 18:26
@Rathoz
Copy link
Copy Markdown
Collaborator

Rathoz commented Jun 3, 2026

You can ask Kano to manually convert the TC to TP on the tournaments that lead to ENC points

@Eetwalt
Copy link
Copy Markdown
Collaborator Author

Eetwalt commented Jun 3, 2026

You can ask Kano to manually convert the TC to TP on the tournaments that lead to ENC points

@fregerson just volunteered actually 👏

@fregerson
Copy link
Copy Markdown
Collaborator

You can ask Kano to manually convert the TC to TP on the tournaments that lead to ENC points

@fregerson just volunteered actually 👏

I think I am done with this fwiw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: team_participant g: honorofkings Honor of Kings / Arena of Valor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants