Conversation
There was a problem hiding this comment.
Pull request overview
Adds an Honor of Kings-specific Legacy TeamCard customization to restore auto role icons (via slot-index position defaulting) when running through the newer TeamParticipants pipeline, and adjusts HoK in-game role ordering so the “by sortOrder” index mapping aligns with standard 5-player lineups.
Changes:
- Added
lua/wikis/honorofkings/TeamCard/Legacy/Custom.luaimplementingpreprocessCardto migrate legacyposNparams and default missingpNposby slot index. - Renumbered
sortOrderinlua/wikis/honorofkings/InGameRoles.luato a contiguous lineup order soINGAME_ROLES_BY_ORDER[1..5]resolves correctly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lua/wikis/honorofkings/TeamCard/Legacy/Custom.lua | Adds HoK-specific Legacy TeamCard hook to migrate/normalize position params and default roles by slot index. |
| lua/wikis/honorofkings/InGameRoles.lua | Updates role sortOrder values to ensure consistent lineup ordering for slot-index role defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
For slot index remapping on ENC games, it may need to wait until after the cut offs. There is a risk that it will move points between players. Only can be done if all ENC tournaments is already using TP |
Oh, maybe we should then wait for cut offs on the TP rollout then for wikis that need the remapping as missing role icons doesn't look great especially for pages that are inputting some roles manually and some rely on import. The changes from this PR is live for HoK via dev modules, so if this is blocker I will revert the template conversions |
Just checked and most ENC tournaments are using TCs so rolling back now just to be safe |
|
You can ask Kano to manually convert the TC to TP on the tournaments that lead to ENC points |
@fregerson just volunteered actually 👏 |
I think I am done with this fwiw |
Summary
Module:TeamCard/Legacy/Customfor honorofkings so pos-less cards (KPL / HoK International style) recover their auto role icons under the new TeamParticipants pipeline via slot-index defaultingInGameRolessortOrderto a contiguous lineup order (top=1, jungler=2, mid=3, bottom=4, roamer=5, side lane=6, flex=7) soINGAME_ROLES_BY_ORDER[1..5]resolves correctly — standard 5-man lineups sort unchangedHow did you test this change?
dev (live in prod)