feat(match2): skirmish data input for valorant#7594
Open
ElectricalBoy wants to merge 8 commits into
Open
Conversation
hjpalpha
reviewed
Jun 2, 2026
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
not a fan
is this really needed?
Collaborator
Author
right now they are squishing this data into match2 comment which is arguably worse |
mbergen
reviewed
Jun 2, 2026
| return { | ||
| players = {player1, player2}, | ||
| scores = scores, | ||
| winner = tonumber(skirmishData.winner) or (scores[1] > scores[2] and 1 or 2) |
Collaborator
There was a problem hiding this comment.
This would be incorrect in case someone enters scores for unfinished skirmishes, right?
Collaborator
Author
There was a problem hiding this comment.
adjusted the fallback to only be applied if the match is finished: 0bfc40f
ElectricalBoy
force-pushed
the
val-skirmish-data
branch
from
6faac84 to
0dadf43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
context: https://x.com/ValorantEsports/status/2011453254891110603
This PR adds parsing&display support for skirmish data input.
Why not store as a separate game?
Skirmish is not a "game" in the context of match2, as it (1) involves only a subset of players (1 player from each team), (2) does not use the full 'first to 13 with overtime' scheme and (3) its result does not affect the match score. Thus, it seems more fitting to store it under
match2.extradata.How did you test this change?
dev