docs(changelog): add the missing SE-273 security fragment - #198
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SE-273: MCP read-only authorization let writing SQLite
PRAGMAs through.The fix itself is already on
developThe classifier change landed in 80761cd, merged via #178 on 2026-08-31.
PRAGMAis no longer a readkeyword. Only allow-listed introspection pragmas without an assignment (
table_info,index_list,foreign_key_list,integrity_check, …) classify asRead. Every other pragma isDdl, whichincludes the
= valueandname(value)setter forms and anything not on the list.Ddlis onlypermitted for
Sandbox. The tests the ticket requires are inMcpSqlClassifierTests:PRAGMA user_version = 999andPRAGMA journal_mode = OFFare refused under ReadOnly, andPRAGMA table_info('x')is still allowed.What this PR adds
That merge shipped without a
changelog.dfragment, so the next release notes would not havementioned a security fix. This PR adds
changelog.d/SE-273.security.mdand nothing else.Verification
dotnet test tests/DataTray.Core.Tests --filter Mcp: 40 passed, 0 failed.under ReadOnly:
pragma\tuser_version=1,PRAGMA/**/user_version=1,PRAGMA "user_version" = 1,PRAGMA journal_mode('OFF'),PRAGMA wal_checkpoint(TRUNCATE),PRAGMA optimize,PRAGMA incremental_vacuum(10),PRAGMA writable_schemaand a;-chained second pragma.Notes, not changed here
PRAGMA journal_mode(a query, not a set) is refused under ReadOnly because it is not on theallow-list. That is safe, but stricter than the ticket's example.
(, soPRAGMA table_info('x') user_versionclassifies asRead. SQLiteitself rejects that as a syntax error, so it gives no write path.