automated: linux: kselftest: Don't skip the main rseq tests#625
Merged
Conversation
The rseq run_params_test.sh runner is currently skipped, according to the changelog due to it being very slow (the comments in the file don't agree but appear to be bitrotted). While it is slow it's the main test here and does work, remove the skip since this is more a policy decision for individual testers than something that's actively broken. Signed-off-by: Mark Brown <broonie@kernel.org>
Member
|
Good spot @broonie. We need to probably re-think that skip list, as its very easy for it to end up in bit-rot state, and its easy for skips tests to make it back into service. |
bhcopeland
approved these changes
Apr 24, 2026
Contributor
Author
|
Yes, I was looking at the rest of the file and thinking it probably needed an audit (there's comments about v4.0 in there!). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rseq run_params_test.sh runner is currently skipped, according to
the changelog due to it being very slow (the comments in the file don't
agree but appear to be bitrotted). While it is slow it's the main test
here and does work, remove the skip since this is more a policy decision
for individual testers than something that's actively broken.
Signed-off-by: Mark Brown broonie@kernel.org