fix(mdbx): restore optional build - #114
Merged
Merged
Conversation
MDBX support was hidden behind an opt-in flag, so CI did not compile the backend test or the example path. The backend also relied on private Logger internals and lacked the value serialization contract required by mdbx-containers. Constraint: keep vendored mdbx-containers unchanged Directive: LOGIT_WITH_MDBX requires C++17 or newer Confidence: high Scope-risk: moderate Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The typed Logger backend accessor should not expose a mutable backend pointer through a const Logger instance. Split it into mutable and const overloads so the public API matches the registry constness. Constraint: keep existing mutable macro behavior unchanged Confidence: high Scope-risk: narrow Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replacement PR
This replaces #113. The previous PR was opened from feat/mdbx-logger after main already contained the squashed MDBX feature work, so GitHub showed the old MDBX diff again and reported merge conflicts. This branch was recreated from current origin/main and contains only the incremental fix.
Verification
🤖 Generated with Claude Code