chore: bump Go toolchain to 1.26.5 to clear stdlib advisories - #83
Merged
Conversation
Closes #77. PR #73's `agent-init upgrade` introduced a net/http path that makes govulncheck report stdlib advisories reachable from selfupdate. #77 asked for go1.26.4 to clear GO-2026-5037/5039; bumping there clears those two but govulncheck then surfaces GO-2026-5856 (crypto/tls Encrypted Client Hello privacy leak), reachable through the same HTTP path and fixed in go1.26.5. To satisfy the issue's "check.sh runs clean" acceptance criterion rather than just its literal version, this pins go1.26.5. Verified: `govulncheck ./...` reports "No vulnerabilities found"; build, vet, and the full test suite pass. CI reads the version via `go-version-file: go.mod`, so no CI/devcontainer pin changes are needed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #77.
What
Bump the
toolchaindirective ingo.modfromgo1.26.3togo1.26.5.Why 1.26.5 and not 1.26.4
#77 asked for 1.26.4 to clear GO-2026-5037 / GO-2026-5039, which PR #73's new
net/httppath madegovulncheckreport. Bumping to 1.26.4 does clear those two — butgovulncheckthen surfaces a newer stdlib advisory, GO-2026-5856 (Encrypted Client Hello privacy leak incrypto/tls), reachable through the same HTTP path ininternal/selfupdateand fixed in go1.26.5.The issue's acceptance criterion is "confirm
check.shruns clean afterward (advisory cleared)," which only 1.26.5 satisfies. So this pins 1.26.5 rather than the literal 1.26.4.Verification
govulncheck ./...→ No vulnerabilities found (was: GO-2026-5037/5039 on 1.26.3; GO-2026-5856 on 1.26.4).go build,go vet, andgo test ./...all pass on 1.26.5.go-version-file: go.mod(.github/actions/setup/action.yml,.github/workflows/release.yml).Scope kept to the toolchain bump; no dependency changes.
🤖 Generated with Claude Code