Fix: Support interactive terminal menu on Windows#39
Merged
Conversation
ChitoKim
requested review from
ethanwharris,
justusschock and
k223kim
as code owners
July 23, 2026 19:43
justusschock
approved these changes
Jul 24, 2026
justusschock
enabled auto-merge (squash)
July 24, 2026 13:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where CLI commands with interactive menus (e.g.,
lightning login,lightning studio start) crash on Windows. Thesimple-term-menudependency relies ontermios, which is not available on Windows.Solution
TerminalMenuwrapper (terminal_menu_wrapper.py) usinginquirerexclusively for Windows (os.name == 'nt').inquireras a conditional dependency (sys_platform == 'win32') and restrictedsimple-term-menuto non-Windows environments (sys_platform != 'win32').Testing
lightning loginandlightning studio startwork flawlessly on a local Windows environment.pre-commithooks (Ruff, TOML formatters) pass successfully.