Skip to content

Fix: Support interactive terminal menu on Windows#39

Merged
justusschock merged 8 commits into
Lightning-AI:mainfrom
ChitoKim:main
Jul 24, 2026
Merged

Fix: Support interactive terminal menu on Windows#39
justusschock merged 8 commits into
Lightning-AI:mainfrom
ChitoKim:main

Conversation

@ChitoKim

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes an issue where CLI commands with interactive menus (e.g., lightning login, lightning studio start) crash on Windows. The simple-term-menu dependency relies on termios, which is not available on Windows.

Solution

  • Added a TerminalMenu wrapper (terminal_menu_wrapper.py) using inquirer exclusively for Windows (os.name == 'nt').
  • Updated the import statements across the CLI module to use the new wrapper.
  • Added inquirer as a conditional dependency (sys_platform == 'win32') and restricted simple-term-menu to non-Windows environments (sys_platform != 'win32').
  • Impact: Zero impact on Linux/macOS users, while bringing full CLI interactive menu support to Windows users.

Testing

  • Verified lightning login and lightning studio start work flawlessly on a local Windows environment.
  • Checked that pre-commit hooks (Ruff, TOML formatters) pass successfully.

@ethanwharris ethanwharris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justusschock
justusschock enabled auto-merge (squash) July 24, 2026 13:28
@justusschock
justusschock merged commit f69b0af into Lightning-AI:main Jul 24, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants