feat(sdk): add availableInNonAwsProviders to V1AwsDataConnection model#34
Merged
Merged
Conversation
pwgardipee
requested review from
ethanwharris,
justusschock and
k223kim
as code owners
July 22, 2026 03:08
pwgardipee
changed the title
andyland
approved these changes
Jul 22, 2026
k223kim
approved these changes
Jul 22, 2026
k223kim
left a comment
k223kim
left a comment
Contributor
There was a problem hiding this comment.
Should we also update the go sdk side as well?
Mirror the Python model change so the Go SDK deserializer preserves availableInNonAwsProviders from API responses instead of dropping it. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
good call @k223kim! just added |
owbone
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
availableInNonAwsProvidersfield to theV1AwsDataConnectionmodel in both the Python and Go SDKs.Without the field on the model, the generated deserializer silently drops
availableInNonAwsProvidersfrom API responses, so downstream consumers (e.g. litData) always see it as unset and can't route those S3 connections through the temporary project-role credential path used for non-AWS providers.This syncs the SDK's vendored copies with the field already present in the grid-generated clients.
Changes
python/.../v1_aws_data_connection.py): field added toswagger_types,attribute_map,__init__, and getter/setter (swagger-codegen style).go/internal/lightningcloud/openapi/generated/models/v1_aws_data_connection.go):AvailableInNonAwsProviders booladded to the struct (go-swagger style), matching the grid go-client ordering/comment.Notes