fix: parse table cells through MyST's prose parser, not literal text - #16
Open
pancakereport wants to merge 1 commit into
Open
Conversation
astra-directive table output (CSV/JSON artifacts) built cells with the raw text() AST helper, bypassing myst-parser entirely. LaTeX ($...$), emphasis, and links in cell data rendered as literal characters instead of real inline nodes, unlike MyST's native csv-table/list-table directives, which nested-parse every cell as prose. tableNodeFromData now runs each header/cell through prose.inline(), the same parser already used for captions and the input/output registry's description column, so table output stays consistent with the rest of MyST rather than reimplementing its own cell rendering. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Author
|
@cailmdaley I think this is your fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
astra-directive table output (CSV/JSON artifacts) built cells with the raw text() AST helper, bypassing myst-parser entirely. LaTeX ($...$ ), emphasis, and links in cell data rendered as literal characters instead of real inline nodes, unlike MyST's native csv-table/list-table directives, which nested-parse every cell as prose.
tableNodeFromData now runs each header/cell through prose.inline(), the same parser already used for captions and the input/output registry's description column, so table output stays consistent with the rest of MyST rather than reimplementing its own cell rendering.
Not sure if this is the only fix needed to close #15, but it solves the named issue there.