Skip to content

Close EVM confirmation from modal registry - #1533

Merged
osyed merged 1 commit into
mainfrom
agent/align-modal-close-apis-on-evm
Aug 4, 2026
Merged

Close EVM confirmation from modal registry#1533
osyed merged 1 commit into
mainfrom
agent/align-modal-close-apis-on-evm

Conversation

@dnlbui

@dnlbui dnlbui commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

What Changed

This PR makes browser-back dismissal close the shared send confirmation modal correctly for both Liberdus and EVM sends.

  • Moves sendAssetConfirmModal from the standard close-handler set to a controller-specific registry entry.
  • Cancels any pending EVM confirmation before closing the shared modal element.
  • Keeps the existing Liberdus confirmation close behavior unchanged.

Fixed Flow

  1. An EVM transfer opens sendAssetConfirmModal and waits for confirmation.
  2. The user dismisses the modal with browser back.
  3. The registry resets the pending EVM confirmation and closes the shared modal.
  4. The transfer flow resolves as cancelled instead of relying on mutation-observer cleanup.

Why

The EVM confirmation controller and the existing Liberdus controller share the same modal DOM ID. The standard registry entry only invoked the Liberdus controller, so EVM cancellation depended indirectly on observing the modal class change. The custom handler closes both pieces of state explicitly.

Validation

  • node --check app.js
  • node --check evm-assets.js
  • git diff --check origin/main..HEAD

@dnlbui
dnlbui force-pushed the agent/align-modal-close-apis-on-evm branch from ad09815 to 95d57db Compare August 4, 2026 23:34
@dnlbui dnlbui changed the title Add modal close registry coverage Close EVM confirmation from modal registry Aug 4, 2026
@dnlbui
dnlbui changed the base branch from agent/evm-send-signature-modal to main August 4, 2026 23:34
@dnlbui
dnlbui marked this pull request as ready for review August 4, 2026 23:35
@osyed
osyed merged commit 75c20d3 into main Aug 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants