Add ISO yyyy-mm-dd date format option - #6
Open
adeldegan-cli wants to merge 3 commits into
Open
Conversation
Adds a third date format choice (ISO 8601: yyyy-mm-dd with 24h clock) alongside the existing European and US formats, selectable from the web interface. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds an ISO-style date format option to Deskbuddy’s web settings and ensures the preference is persisted/validated, enabling users to choose yyyy-mm-dd formatting (with the existing weekday prefix) alongside the existing EU/US options.
Changes:
- Added
isoas a validregionFormatKeyvalue and included it in settings validation/fallback logic. - Updated date rendering to select among EU/US/ISO
strftimepatterns. - Added an ISO option to the web UI “Date format” dropdown.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| String textColorKey = "standard"; | ||
| String unitKey = "metric"; // metric = C/mm, imperial = F/in | ||
| String regionFormatKey = "europe"; // europe = 24h + dd.mm.yyyy, us = 12h + mm/dd/yyyy | ||
| String regionFormatKey = "europe"; // europe = 24h + dd.mm.yyyy, us = 12h + mm/dd/yyyy, iso = 24h + yyyy-mm-dd |
- New 5th nav page 'Ctrl' with two integrations, each hidden unless its
token is set in secrets.h:
- NIM Hub: shows the running timer (elapsed, description, paused state,
polled every 10s while the page is visible), with Pause/Resume and
Stop & Save buttons. Stop & Save posts the time entry first and only
then deletes the timer, and never retries the save, so a failed second
step can't double-log hours.
- Hermes Ear: shows listening state (polled every 5s) with a single
Start/Stop toggle against the Jetson's LAN control API.
- WiFi + API credentials move to a gitignored secrets.h
(secrets.h.example documents the format); the sketch falls back to
placeholder defines so the public repo still compiles.
- SETUP_GUIDE: secrets.h instructions + Huge APP partition note (the
sketch passed 94% of the default partition).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Lag fix — button presses froze the UI for 2-6s because every action ran
2-3 sequential HTTPS calls (each a fresh TLS handshake) on the UI thread,
and the 10s background poll blocked touch handling too:
- All controls HTTP now runs on a FreeRTOS worker task pinned to core 0;
the UI enqueues a command and keeps drawing ('Working...' feedback is
immediate, results repaint when the worker finishes)
- Persistent WiFiClientSecure with setReuse keeps the TLS session alive
between calls, cutting each request to a single round trip
- Pause/resume now apply the timer from the action response instead of
re-polling; stop&save skips the re-poll on success
- Shared Strings guarded by a mutex; primitives are atomic on Xtensa
Weather and Notes pages parked per request — nav is now Home/Status/Ctrl
via a NAV_PAGES mapping table; the page code stays compiled and both
pages restore by uncommenting their NAV_PAGES/NAV_NAMES entries and
dispatch cases. Weather data still refreshes for the Home widgets.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a third choice to the Date format dropdown in the web interface: ISO 8601 (yyyy-mm-dd) with a 24-hour clock, alongside the existing European and US formats.
Changes:
isovalue forregionFormatKey, rendered as%a %Y-%m-%d(e.g.Sun 2026-08-17)loadStoredSettings()andhandleSave()so the new key round-trips through Preferenceseurope/usbehavior unchanged; unknown values still fall back toeuropeTested on an ESP32-2432S028R (CYD, ST7789 variant): builds clean, format selectable and persists across reboots, date renders correctly on the display.
🤖 Generated with Claude Code