Skip to content

chore: promote develop to main (severino-bot + lerian-hq matrix entries)#375

Merged
ferr3ira-gabriel merged 4 commits into
mainfrom
develop
May 15, 2026
Merged

chore: promote develop to main (severino-bot + lerian-hq matrix entries)#375
ferr3ira-gabriel merged 4 commits into
mainfrom
develop

Conversation

@ferr3ira-gabriel
Copy link
Copy Markdown
Member

@ferr3ira-gabriel ferr3ira-gabriel commented May 15, 2026

What

Promotes developmain. Batches 2 feature PRs already merged into develop:

PR Change
#368 Register lerian-hq in deployment matrix (benedita)
#374 Register severino-bot in deployment matrix (benedita)

Diff

Single file: config/deployment-matrix.yml (+7 / -1):

  • apps.registry: adds lerian-hq and severino-bot
  • clusters.benedita.apps: adds both apps to benedita's resolved cluster list

Why now

Callers of gitops-update.yml resolve the deployment matrix from main at runtime (the workflow's default deployment_matrix_ref). Both apps need their matrix entries on main before their respective build pipelines can run update_gitops end-to-end.

Risk

Zero runtime risk. config/deployment-matrix.yml is in self-release.yml's paths-ignore — matrix-only promotions don't cut a new shared-workflows tag. The change takes effect immediately on merge for all callers on the current shared-workflows version.

Summary by CodeRabbit

  • Chores
    • Updated deployment configuration to enable new applications lerian-hq and severino-bot for deployment.

Review Change Stack

lerian-studio and others added 4 commits May 14, 2026 19:37
* feat: register lerian-hq in deployment matrix (benedita)

Adds lerian-hq to apps.registry and clusters.benedita.apps so the
gitops-update reusable workflow can resolve benedita as a deployment
target for the lerian-hq app.

Scope: benedita only — lerian-hq is an internal hub deployed via the
midaz-firmino-gitops overlay at environments/benedita/.../lerian-hq.
Not deployed to clotilde / anacleto / firmino.

* chore: relabel platform-suite section (Clotilde + Benedita)

The 'Clotilde-exclusive' comment was outdated already (lerian-map,
forge, backoffice-console, cs-platform, tenant-manager all run on
benedita too). Renaming this section in the same change that introduces
lerian-hq under it.

---------

Co-authored-by: Primo Soares <primo@lerian.studio>
severino-bot is moving from firmino (kustomize/severino) to benedita
in midaz-firmino-gitops. This registers the app so the upcoming
build.yml -> update_gitops job can resolve the target cluster at
runtime when severino-bot release tags are cut.

- apps.registry: add severino-bot under a new 'Benedita-exclusive'
  section (mirrors the existing 'Anacleto-exclusive' grouping)
- clusters.benedita.apps: add severino-bot to the resolved list
…in-deployment-matrix

feat(deployment-matrix): register severino-bot for benedita
@ferr3ira-gabriel ferr3ira-gabriel requested a review from a team as a code owner May 15, 2026 19:48
@lerian-studio lerian-studio added size/XS PR changes < 50 lines deployment-matrix Changes to the canonical deployment matrix (config/deployment-matrix.yml) labels May 15, 2026
@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 15, 2026

🔍 Lint Analysis

Check Files Scanned Status
YAML Lint 1 file(s) ✅ success
Action Lint no changes ⏭️ skipped
Pinned Actions no changes ⏭️ skipped
Markdown Link Check no changes ⏭️ skipped
Spelling Check 1 file(s) ✅ success
Shell Check no changes ⏭️ skipped
README Check no changes ⏭️ skipped
Composite Schema no changes ⏭️ skipped
Deployment Matrix 1 file(s) ✅ success

🔍 View full scan logs

@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 15, 2026

🔍 PR Validation Summary

✅ PR Mergeable — no blocking failures

Check Status Blocking
Source Branch ✅ success yes
PR Title ✅ success yes
PR Description ✅ success yes
PR Size ✅ success no
Auto Labels ✅ success no
PR Metadata ✅ success no

🔍 View workflow run

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2dec1c63-aabd-4ac7-93a3-5e8bd48ff6ac

📥 Commits

Reviewing files that changed from the base of the PR and between ddf45f5 and 66b3fa7.

📒 Files selected for processing (1)
  • config/deployment-matrix.yml

Walkthrough

Updated config/deployment-matrix.yml to register lerian-hq and severino-bot in the global app allowlist, reorganized app grouping comments to reflect internal suite and per-cluster exclusivity, and added both applications to the benedita cluster's deployment configuration.

Changes

Deployment Matrix Configuration Update

Layer / File(s) Summary
App registry and benedita cluster deployment configuration
config/deployment-matrix.yml
apps.registry allowlist expanded with lerian-hq and severino-bot; organizational comments restructured to group Lerian suite, Anacleto-exclusive, and Benedita-exclusive apps. The benedita cluster's apps list updated to include both new apps alongside existing Lerian suite applications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

size/XS, deployment-matrix

Suggested reviewers

  • bedatty
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive PR description is well-structured and complete, covering what changed, why it's needed, and risk assessment. However, it does not match the repository's description template for workflow changes. Clarify whether this PR is a promotion/chore or a feature PR requiring the full template with Type of Change and Testing sections. If promotion-only, the current description is appropriate; if it's bundling features, use the template format.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed Title accurately describes the main change: promoting develop to main with two deployment matrix entries (severino-bot and lerian-hq).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@ferr3ira-gabriel ferr3ira-gabriel merged commit 94b8b32 into main May 15, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment-matrix Changes to the canonical deployment matrix (config/deployment-matrix.yml) size/XS PR changes < 50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants