Conversation
lerian-notification is the new Core-platform service onboarded in firmino-dev (see LerianStudio/midaz-firmino-gitops#664). Without the matrix entry, the upstream build.yml's update_gitops job — which now relies on this file as the source of truth for cluster routing — resolves to an empty cluster list and skips the gitops bump. Add the app to: - apps.registry under "Core platform" (next to fetcher, matcher, product-console, ...). - clusters.firmino.apps. Only firmino is in scope today; the other cluster manifests stay unchanged. When the app is onboarded to another cluster, that cluster's apps: block adds it (and only it). Co-authored-by: Gabriel Ferreira <39352130+ferr3ira-gabriel@users.noreply.github.com>
The self pr-validation suite (title check, scope check, source-branch enforcement, etc.) only listened to opened/synchronize/reopened. Editing the PR title or body did not retrigger the check, so a fix applied via the GitHub UI would leave the validation in its previous (possibly failed) state until someone pushed a new commit. Add the two missing event types: - edited: covers title / body / base-ref changes from the GitHub UI. This is what every reusable pr-validation.yml caller listens to (e.g., the standardize-repo template emitted into consumer repos), so the self suite should match. - ready_for_review: covers draft -> ready transitions, which is when reviewers actually need the validation result to be current. No change to the validation logic itself — just broader trigger.
Bumps the security-scanners group with 1 update: [trufflesecurity/trufflehog](https://github.com/trufflesecurity/trufflehog). Updates `trufflesecurity/trufflehog` from 3.95.2 to 3.95.3 - [Release notes](https://github.com/trufflesecurity/trufflehog/releases) - [Commits](trufflesecurity/trufflehog@17456f8...37b7700) --- updated-dependencies: - dependency-name: trufflesecurity/trufflehog dependency-version: 3.95.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: security-scanners ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
WalkthroughThree independent infrastructure updates: TruffleHog action version bump from v3.95.2 to v3.95.3, expanded PR validation trigger types to include ChangesRepository Infrastructure Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔍 Lint Analysis
|
🔍 PR Validation Summary✅ PR Mergeable — no blocking failures
|
🛡️ CodeQL Analysis ResultsLanguages analyzed: ✅ No security issues found. 🔍 View full scan logs | 🛡️ Security tab |
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@config/deployment-matrix.yml`:
- Line 44: The inline comment next to lerian-notification referencing
"firmino-dev only today" is ambiguous relative to the cluster name "firmino";
update the comment for clarity by stating whether this entry targets the firmino
cluster's development namespace (e.g., "firmino (dev namespace) only today") or
that it is production-ready for firmino (e.g., "firmino production"), and if it
truly is limited to a non-production environment, mark it explicitly (e.g.,
"dev-only; do not merge to main") so reviewers know merging to main is
premature; edit the comment near the lerian-notification line in
deployment-matrix.yml accordingly.
- Line 44: The deployment-matrix entry "lerian-notification" is marked
"firmino-dev only today" but is being merged to main without GitOps artifacts;
either remove the "lerian-notification" line from deployment-matrix.yml before
merging, move that change to the develop branch instead of main, or add the
required GitOps artifacts (values.yaml, kustomization, and any cluster-specific
deployment manifests) and update the inline comment to reflect intentional
production deployment to the firmino cluster.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 64763dfd-51f1-4dd8-9646-cdc002baa7fd
📒 Files selected for processing (3)
.github/workflows/go-security.yml.github/workflows/self-pr-validation.ymlconfig/deployment-matrix.yml
GitHub Actions Shared Workflows
Description
Type of Change
feat: New workflow or new input/output/step in an existing workflowfix: Bug fix in a workflow (incorrect behavior, broken step, wrong condition)perf: Performance improvement (e.g. caching, parallelism, reduced steps)refactor: Internal restructuring with no behavior changedocs: Documentation only (README, docs/, inline comments)ci: Changes to self-CI (workflows under.github/workflows/that run on this repo)chore: Dependency bumps, config updates, maintenancetest: Adding or updating testsBREAKING CHANGE: Callers must update their configuration after this PRBreaking Changes
None.
Testing
@this-branchor the beta tagCaller repo / workflow run:
Related Issues
Closes #
Summary by CodeRabbit
Chores
Infrastructure