Skip to content

When queuing calls to the main thread which present speech or braille to the user, ensure they are executed immediately. #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeonarddeR merged 1 commit into from
Jul 28, 2026
Merged

When queuing calls to the main thread which present speech or braille to the user, ensure they are executed immediately. #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addon/globalPlugins/rdAccess/handlers/remoteBrailleHandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def _command_display(self, cells: list[int]):
with self._queuedWriteLock:
self._queuedWrite = cells
if not braille.handler.enabled and self.hasFocus:
self._queueFunctionOnMainThread(self._performLocalWriteCells)
self._queueFunctionOnMainThread(self._performLocalWriteCells, _immediate=True)
elif self._remoteSessionhasFocus is False:
self.requestRemoteAttribute(protocol.GenericAttribute.TIME_SINCE_INPUT)

Expand All @@ -107,7 +107,7 @@ def _performLocalWriteCells(self):

def _handleRemoteSessionGainFocus(self):
super()._handleRemoteSessionGainFocus()
self._queueFunctionOnMainThread(self._performLocalWriteCells)
self._queueFunctionOnMainThread(self._performLocalWriteCells, _immediate=True)

def _handleExecuteGesture(self, gesture):
assert braille.handler is not None
Expand Down
6 changes: 3 additions & 3 deletions addon/globalPlugins/rdAccess/handlers/remoteSpeechHandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def _outgoing_language(self, language: str | None = None) -> str | None:

@protocol.commandHandler(protocol.RdMessageType.SPEAK)
def _command_speak(self, sequence: SpeechSequence):
self._queueFunctionOnMainThread(self._speak, sequence)
self._queueFunctionOnMainThread(self._speak, sequence, _immediate=True)

def _speak(self, sequence: SpeechSequence):
pitchChange = configuration.getIncomingSpeechPitchChange(fromCache=True)
Expand All @@ -80,7 +80,7 @@ def _speak(self, sequence: SpeechSequence):
@protocol.commandHandler(protocol.RdMessageType.CANCEL)
def _command_cancel(self):
self._indexesSpeaking.clear()
self._queueFunctionOnMainThread(self._cancel)
self._queueFunctionOnMainThread(self._cancel, _immediate=True)

def _cancel(self):
self._driver.cancel()
Expand All @@ -90,7 +90,7 @@ def _cancel(self):

@protocol.commandHandler(protocol.RdMessageType.PAUSE_SPEECH)
def _command_pause(self, switch: bool):
self._queueFunctionOnMainThread(self._pause, switch)
self._queueFunctionOnMainThread(self._pause, switch, _immediate=True)

def _pause(self, switch: bool):
speech.pauseSpeech(switch)
Expand Down