Repository navigation
test: pin leo-sdk-nodejs behavior as the reference for rstreams-rs parity - #228
Open
mecham-lynn wants to merge 19 commits into
Open
mecham-lynn wants to merge 19 commits into
mecham-lynn wants to merge 19 commits into
Conversation
Compiled TS files were remapped to .ts keys, so per-file coverage for lib/event-trace.js and lib/rstreams-config-provider-chain.js could not be read by filename. Disable source-map remapping and the instrument cache. Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… flow Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nularities Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ok, load Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ich/offload Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…hooks, snapshot/archive Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ate listeners Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Assert the kept S3 request handler, pin the single-event queue partition key, replace wall-clock waits with deferred promises, isolate leosdk/RSTREAMS_CONFIG env keys in the provider-chain tests, and strip plan ids from titles. Restore .nycrc.json to master (guard passes the flags instead). Task: TASK-002 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 5a9aca87-973f-4480-bd5f-e6518ecf9db1) |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
LeoPlatform now rejects actions referenced by tag, so the PR's CI matrix failed at job setup. Pins checkout v3.7.0, setup-node v3.9.1 and upload-artifact v4.6.2 (same majors as before). Task: TASK-002 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: c5e8132b-24dd-4ba3-866b-c295593e2e22) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests only, with no source changes. This pins leo-sdk-nodejs's behavior as the reference that rstreams-rs (Rust) is being brought to parity with.
test/*.utest.ts(sinon + chai, in the style oftest/lib.cron.utest.ts) cover:toLeo(Kinesis/Firehose/S3, partitioning, backoff,toCheckpoint)fast_s3_readretries and read hooksdynamodb.jschild_process.forkis stubbed in the fanout tests. Outside Lambda,wrappers/fanout.jsforksprocess.argv[1], which under mocha re-runs mocha.Evidence
301 → 685 passing tests.
Line coverage on the files the Rust port is checked against:
lib/cron.jsrstreams-config-provider-chainwrappers/fanout.jslib/dynamodb.jslib/stream/leo-stream.jsevent-traceDeliberate breaks of the lock condition, the stale-checkpoint condition, and config secret order are each caught by a failing test.
Found while writing the tests and recorded rather than changed, since this PR changes no source: a rejected combined Firehose put is retried as the first record only (
leo-stream.js:876-896), so the rest of that payload is dropped.Testing
Companion PR in Chub-Engineering/rstreams-rs uses these behaviors as its oracle.
Task: TASK-002 (no Jira yet)
🤖 Generated with Claude Code
Note
Low Risk
Tests, documentation, and CI action pinning only; runtime SDK behavior is unchanged.
Overview
Adds a large behavioral test suite (TypeScript
test/*.utest.ts, run as compiled*.utest.js) to lock in leo-sdk-nodejs as the reference for rstreams-rs parity. Coverage spans config resolution order, cron lifecycle, DynamoDB helpers,leo-streamread/write paths (includingfast_s3_read), event IDs, event-trace, and the fanout wrapper—with DynamoDB/AWS clients stubbed via sinon.Also adds AGENTS.md (build/test conventions, gotchas) and CLAUDE.md (alias to AGENTS.md). CI pins
actions/checkout,setup-node, andupload-artifactto specific commit SHAs instead of floating@v3/@v4tags.No production library code changes.
Reviewed by Cursor Bugbot for commit e26d877. Bugbot is set up for automated code reviews on this repo. Configure here.